1944496 - [wpt-sync] Sync PR 50363 - Raise for the race-network-and-fetch-handler source without handler

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50363 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50363
Details from upstream follow.

Yoshisato Yanagisawa <[e-mail]> wrote:

Raise for the race-network-and-fetch-handler source without handler

This reflects the change in https://github.com/w3c/ServiceWorker/pull/1719.
Instead of silently fallback to network, let me make addRoutes() raise
if the race-network-and-fetch-handler source is used without having a
fetch handler.

Fixed: 391990601
Change-Id: Ic944e183286cd056235b0fe272c543533dfaa86f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6211317
Reviewed-by: Takashi Toyoshima \<[e-mail]>
Commit-Queue: Yoshisato Yanagisawa \<[e-mail]>
Reviewed-by: Shunya Shishido \<[e-mail]>
Reviewed-by: Hidehiko Abe \<[e-mail]>
Reviewed-by: Keita Suzuki \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1412763}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9200dbaa5676d5d9710ba7ff8dd308b3535629f8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
FAIL: 3

Chrome

OK : 1
PASS: 2
FAIL: 1

Safari

OK : 1
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /service-workers/service-worker/static-router-no-fetch-handler.https.html [wpt.fyi]
  • The router rule is evaluated without fetch handlers in service worker: FAIL (Chrome: PASS, Safari: FAIL)
  • addRoutes should raise if the fetch-event source is used without onfetch: FAIL (Chrome: PASS, Safari: FAIL)
  • addRoutes should raise if the race-network-and-fetch-handler source is used without onfetch: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ae5a8a8ad4e
[wpt PR 50363] - Raise for the race-network-and-fetch-handler source without handler, a=testonly
https://hg.mozilla.org/integration/autoland/rev/ef6dc3cbf0f3
[wpt PR 50363] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/9ae5a8a8ad4e
https://hg.mozilla.org/mozilla-central/rev/ef6dc3cbf0f3