Closed Bug 1944597 Opened 15 days ago Closed 14 days ago

Language name missing from the "Translated to <language>" menu item

Categories

(Fenix :: Translations, defect)

Firefox 136
All
Android
defect

Tracking

(firefox134 unaffected, firefox135 unaffected, firefox136 fixed)

RESOLVED FIXED
136 Branch
Tracking Status
firefox134 --- unaffected
firefox135 --- unaffected
firefox136 --- fixed

People

(Reporter: ohorvath, Assigned: olivia)

References

(Regression)

Details

(Keywords: regression, ui-test-bug-auto-found, Whiteboard: [fxdroid], group1, platform)

Attachments

(1 file)

A Translations sheet UI test caught a regression, see Bug 1944521.
STR:

  1. With the new menu enabled, go to a foreign page https://fr.m.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil_principal
  2. Translate to English.
  3. Open again the main menu> Tools.
  4. Check the "Translated to" item.

Expected result: It should say "Translated to English".

Actual result: The language name is missing from the item name.

Possible regressor could be bug 1942349. I'll try to confirm today.

Flags: needinfo?(ohall)
See Also: → 1942349

Thanks for reporting, Oana! Is there a CI run associated with when this was found? I'd like to check some details on it to get a range.

Flags: needinfo?(ohall) → needinfo?(ohorvath)
Flags: needinfo?(ohall)
Flags: needinfo?(ohorvath)
See Also: → 1944599

Looks like it did come from bug 1942349. I have a patch I'll put up for review shortly.

Regressed by: 1942349
Whiteboard: group1, platform
Flags: needinfo?(ohall)
Whiteboard: group1, platform → [fxdroid], group1, platform
See Also: → 1943444
  • The message sent by TranslationsParent:LanguageState was changed in 1942349
  • This caused a regression in GV when deserialization occurred of the value
  • Fix passes on requestedLanguagePair and deserializes sourceLanguage
    and targetLanguage
Assignee: nobody → ohall
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 1942349

Pushed by ohall@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ce3e5b1076ed Changes deserialization in GeckoView for Translations r=geckoview-reviewers,translations-reviewers,nordzilla,calu
Status: ASSIGNED → RESOLVED
Closed: 14 days ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
Blocks: 1944521
Blocks: 1944599
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: