1944914 - SOCK_CLOEXEC is misspelled in an ifdef in ForkServiceChild.cpp

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

The patch for bug 1858272 had a typo in an ifdef, misspelling SOCK_CLOEXEC as SOCK_CLOXEC, so the condition was never true for that ifdef, but was for others. The result was that the close-on-exec flag is never set on those sockets. This isn't a huge bug — Necko still doesn't set close-on-exec, for example, and in general our approach is to ensure that all unwanted fds are explicitly closed for process spawning in our code — but it's a bug.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1858272

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Bug 1944914 - Fix ifdef typo (missing E in `SOCK_CLOEXEC`).

This typo was missed during review, and then I happened to notice it
myself before landing, and… somehow forgot to fix it. The impact is
that we won't use SOCK_CLOEXEC when creating the socketpair, but we
also won't set FD_CLOEXEC non-atomically either, because the other
ifdefs are spelled correctly.

It would be nice to have a regression test for this, given how easy it
was for several people to repeatedly miss it, but there isn't a good way
to do that because this is an internal implementation detail.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a65533b2d91
Fix ifdef typo (missing E in `SOCK_CLOEXEC`). r=ipc-reviewers,mccr8

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6a65533b2d91