1945107 - Fenix crashes when downloading a file with a very long extension

Status: RESOLVED FIXED

(Fenix :: Downloads, defect, P1)

Description

[Vasilica Tamas QA [:vtamas]]

Attachment: FenixCrash.mp4

Steps to reproduce

1. Navigate to https://jsfiddle.net/waktesjv/6/
2. Tap on the download long named file button "dw loooong named file".

Expected behavior

The download prompt is being displayed.

Actual behavior

Fenix crashes.

Device information

• Firefox version: Firefox Nightly 136 (2025-01-31)
• Android device model: Samsung S24 Ultra (Android 14), OPPO A15s (Android 10), Samsung Galaxy A53 5G (Android 14), Motorola Nexus 6 (Android 8), Google Pixel 9 Pro XL (Android 15)

Any additional information?

• Crash id: f657bb0a-2db6-4c59-ba6d-d471406593e6 , 83ee1ac8-056c-412f-9bc9-dc00ac196c10
• This issue is a regression:
  • Last good build: 2025-01-27
  • First bad build: 2025-01-28

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1880023

:calu, since you are the author of the regressor, bug 1880023, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Cathy Lu [:calu]]

That's for catching this. Prior to my fix, the download would just fail. Now with a long extension, the app crashes.

Comment 3

[Julien Wajsberg [:julienw]]

Hey Cathy, what would be the next step for this P1 bug? Thanks!

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1880023

Comment 5

[Cathy Lu [:calu]]

Thanks for the interest Julien, I'm actively working on fixing this.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox136 (beta) and tracked for firefox137 (nightly). However, the bug still isn't assigned.

:007, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 7

[Cathy Lu [:calu]]

Attachment: Bug 1945107 - Prevent crashes when download file extension too long

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd64d83d9fc3
Prevent crashes when download file extension too long r=android-reviewers,tthibaud

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fd64d83d9fc3

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:calu, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox136 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Cathy Lu [:calu]]

Vasilica or QA, could you verify this and make sure this does not result in any other crashes, before we uplift to beta?
This specific case with the long extension name will still fail (it's covered by this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1946152) but that was the behavior before as well.

Comment 12

[Delia Pop (Android QA)]

Attachment: screen-20250212-113525.mp4

Verified as fixed in the latest Nightly 137.0a1 from 02/12. The application no longer crashes and no other issues except for the known exception from 1946152 were observed.
Tested with the following devices:

• Google Pixel 8 Pro (Android 14)
• Samsung Galaxy Note 8 (Android 12)
• OPPO A15s (Android 10)
• Google Pixel 9 (Android 15)
• Samsung S24 Ultra (Android 14)
• LG G7 fit (Android 9)

Comment 13

[Cathy Lu [:calu]]

Comment on attachment 9464113 [details]
Bug 1945107 - Prevent crashes when download file extension too long

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: App crashes when a user downloads a file with a long file extension
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: Already completed
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Now when users download the file, it will just fail and notify the user, whereas before, it would crash the whole app.
• String changes made/needed: No
• Is Android affected?: Yes

Comment 14

[Donal Meehan [:dmeehan]]

Comment on attachment 9464113 [details]
Bug 1945107 - Prevent crashes when download file extension too long

Approved for 136.0b6

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/b60f1951d2c6