Closed Bug 19452 Opened 25 years ago Closed 25 years ago

huge menus

Categories

(Core Graveyard :: Viewer App, defect, P3)

Product:
Core Graveyard
Component:
Viewer App
Platform:
x86
Linux
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: BenB, Assigned: waqar)

References

Details

Build from Nov 20, 1999, 12:00 or so.

Menus are not above, but under the toolbar and use 50% of vertical space.
Horizontal size seems OK.

gtk+ 1.2.3-1 and glib 1.2.3-1.
They are fully funtionaly and overlay the content area, which seems functional,
too.
Assignee: rickg → petersen
Petersen -- can you confirm this? I suspect our bug author means that this
happend in apprunner (mozilla.exe). Viewer menus are hard-wired.
Petersen -- can you confirm this? I suspect our bug author means that this
happend in apprunner (mozilla.exe). I believe that viewer menus are hard-wired.
No, I was refering to the Viewer App (|./mozilla-viewer.sh|).
Since I only have apprunner installed on the linux machine, I will need to
install viewer.
This is a real bug.  It makes it really hard to use viewer.  I was about to
report it myself.
Could this have something to do with the superwin landing?  There were changes
to mozilla/webshell/tests/viewer/unix/gtk/nsGtkMenu.cpp that look a little
suspicious...
Could this have something to do with the superwin landing?  There were changes
to mozilla/webshell/tests/viewer/unix/gtk/nsGtkMenu.cpp that look a little
suspicious...
Assignee: petersen → rickg
QA Contact: leger → rickg
A viewer bug...resetting QA Contact and engineer.
Assignee: rickg → waqar
Ok -- Waqar, can you please take a look at this?
I'm guessing this is a superwin "problem."  It's really an archetecture
problem.  You can't just stick a random widget into the layout engine now and
have it just work without setting the bounds on it.
Status: NEW → ASSIGNED
This morning's (11/29) build seems to work for me. I see normal menus in viewer
and mozilla. How do I reproduce this?
wagar,
I still see the problem. I just do |./mozilla-viewer| in MOZILLA_FIVE_HOME.
dbaron,
can you confirm, that the problem still exists?
I still see the problem.  I'm using gtk+ 1.2.6.  What version do you (waqar)
have?
I am using glib and gtk+ 1.2.5.
I'm using 1.2.5 and don't see this problem either.
Target Milestone: M13
*** Bug 21718 has been marked as a duplicate of this bug. ***
Chris McAfee seems to see this problem (see duplicate).  Chris, what version of
GTK are you using?  You seem to be the only developer who's seen this...
I'm using gtk+ 1.2.3, this is standard for RamiroHat, most internal Netscape
people will have this version.  I don't buy the "I'm the only one seeing this",
other people have mentioned it to me.
Well, waqar and blizzard weren't seeing it (they both use GTK+ 1.2.5).  You're
the only developer to admit in Bugzilla to seeing it.
akkana, you were seeing this too, right?
I've been seeing this for something like a month.  I hadn't bothered to file it
because I figured viewer was an internal tool and none of its users cared about
how gtk menus looked.  It makes it very hard to use viewer to test small pages,
because the menus cover up a large block of the upper left part of the page.

Anyone is welcome to come by any time and see this on my machine.
I have gtk 1.2.3-1 on guitar.  Perhaps this is specific to 1.2.3.
So far, it's seen on 1.2.3 and 1.2.6 and not seen on 1.2.5.
I updated to gtk and glib 1.2.6 and I don't see this problem. Akkana where is
your build. I would like to test it on your machine.
You can use the build in /builds/fri/mozilla/ on guitar.
Here is the fix, if any one has problem with it let me know other wise I will
check this in.
Index: nsGtkMenu.cpp
===================================================================
RCS file: /cvsroot/mozilla/webshell/tests/viewer/unix/gtk/nsGtkMenu.cpp,v
retrieving revision 1.7
diff -r1.7 nsGtkMenu.cpp
175d174
<   gtk_widget_show(mozBox);
176a176
>   gtk_widget_show(mozBox);
Great!  This patch fixes the problem for me (rh60).
If it works for you, check it in.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Fix checked in.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.