Closed
Bug 1945411
Opened 8 days ago
Closed 7 days ago
Reflect asm.js status into the navigation cache
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
137 Branch
Tracking | Status | |
---|---|---|
firefox137 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
The Stencil XDR doesn't support asm.js, and this means any script with effective "use asm"
won't be cached, this means a script with "use asm"
is cached only when asm.js is disabled, for example by debugger.
SharedScriptCache stores all Stencils regardless of whether it contains asm.js or not, which means Stencils with asm.js enabled are also cached,
and the cached Stencil will be used even after attaching debugger and reloading.
We should either:
- (a) Add the asm.js state into the cache key, and store those caches separately
- (b) Stop caching stencils with asm.js in the in-memory cache
If we just inherit the disk cache's case, (b) would be the way to go
Assignee | ||
Comment 1•8 days ago
|
||
Assignee | ||
Comment 2•8 days ago
|
||
Assignee | ||
Comment 3•8 days ago
|
||
Updated•7 days ago
|
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/378b54f501b3
Part 1: Add hasAsmJS accessor to stencil classes. r=nbp
https://hg.mozilla.org/integration/autoland/rev/25c539b97d63
Part 2: Add JS::IsStencilCacheable. r=nbp
https://hg.mozilla.org/integration/autoland/rev/c68a36c3d1d0
Part 3: Do not cache stencil with asm.js. r=nbp
Comment 5•7 days ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/378b54f501b3
https://hg.mozilla.org/mozilla-central/rev/25c539b97d63
https://hg.mozilla.org/mozilla-central/rev/c68a36c3d1d0
Status: ASSIGNED → RESOLVED
Closed: 7 days ago
status-firefox137:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•