Closed Bug 1945474 Opened 16 days ago Closed 15 days ago

Fix some minor issues in search code

Categories

(Firefox :: Search, task, P3)

task

Tracking

()

RESOLVED FIXED
137 Branch
Tracking Status
firefox137 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

As far as I can tell, these all should have no affect / won't affect the majority of people.

  • This code references this.submissionURL however, we never set that on AppProvidedSearchEngine / SearchEngine (the this object).
  • This code is out of date, in that it is still passing an SearchEngine object to EngineURL.getSubmission, rather than passing the character set.
    • Practically, this could affect the update of some OpenSearch engines, if they have a foo={charset} parameter in their update URL, however, most engines don't have an update URL, and I suspect that having a parameter would be a rare case.
  • This code references engine._engineToUpdate, which we no longer set anywhere.
  • This code is unnecessarily passing the null sourceURI as the first argument - the first argument should be the message.
  • This code is unused. It used to be used (ESR 102 link) in OpenSearchEngine, but is no longer required - and we no longer set _uri on the SearchEngine object.
  • This option is no longer necessary, as the SearchEngine parent doesn't keep track of it as we have a specific getter for isAppProvided which is hard coded in the relevant classes.
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/541f70823d5e Fix some minor issues in search code. r=search-reviewers,scunnane
Status: ASSIGNED → RESOLVED
Closed: 15 days ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: