Closed Bug 1945579 Opened 6 days ago Closed 4 days ago

[wpt-sync] Sync PR 50457 - Add new request-close command for dialogs

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
137 Branch
Tracking Status
firefox137 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50457 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50457
Details from upstream follow.

Luke Warlow <lwarlow@igalia.com> wrote:

Add new request-close command for dialogs

This patch adds a new request-close command for dialogs, flagged by
the InvokeActionsV2 flag.

It also implements the behaviour where the command button's value
attribute is used as the returnValue for the dialog, for close
and request-close commands.

Bug: 40284894
Change-Id: Iceee309930939ed64fd62e67bbfcce33cd4131f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6213975
Reviewed-by: Mason Freed \<masonf@chromium.org>
Commit-Queue: Luke \<lwarlow@igalia.com>
Reviewed-by: Keith Cirkel \<chromium@keithcirkel.co.uk>
Cr-Commit-Position: refs/heads/main@{#1414958}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Safari on GitHub CI

Total 2 tests and 50 subtests

Status Summary

Firefox

OK : 2
PASS: 39
FAIL: 41

Safari

OK : 2
PASS: 39
FAIL: 41

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/the-button-element/command-and-commandfor/on-dialog-behavior-request-close.tentative.html [wpt.fyi]
    • invoking to request-close (with command property as request-close) open dialog closes: FAIL (Safari: FAIL)
    • invoking to request-close with value (with command property as request-close) open dialog closes and sets returnValue: FAIL (Safari: FAIL)
    • invoking to request-close (with command property as request-close) open dialog while changing command still closes: FAIL (Safari: FAIL)
    • invoking to request-close (with command property as request-close) open modal dialog while changing command still closes: FAIL (Safari: FAIL)
    • invoking to request-close (with command attribute as request-close) open dialog closes: FAIL (Safari: FAIL)
    • invoking to request-close with value (with command attribute as request-close) open dialog closes and sets returnValue: FAIL (Safari: FAIL)
    • invoking to request-close (with command attribute as request-close) open dialog while changing command still closes: FAIL (Safari: FAIL)
    • invoking to request-close (with command attribute as request-close) open modal dialog while changing command still closes: FAIL (Safari: FAIL)
    • invoking to request-close (with command property as reQuEst-Close) open dialog closes: FAIL (Safari: FAIL)
    • invoking to request-close with value (with command property as reQuEst-Close) open dialog closes and sets returnValue: FAIL (Safari: FAIL)
    • invoking to request-close (with command property as reQuEst-Close) open dialog while changing command still closes: FAIL (Safari: FAIL)
    • invoking to request-close (with command property as reQuEst-Close) open modal dialog while changing command still closes: FAIL (Safari: FAIL)
    • invoking to request-close (with command attribute as reQuEst-Close) open dialog closes: FAIL (Safari: FAIL)
    • invoking to request-close with value (with command attribute as reQuEst-Close) open dialog closes and sets returnValue: FAIL (Safari: FAIL)
    • invoking to request-close (with command attribute as reQuEst-Close) open dialog while changing command still closes: FAIL (Safari: FAIL)
    • invoking to request-close (with command attribute as reQuEst-Close) open modal dialog while changing command still closes: FAIL (Safari: FAIL)
  • /html/semantics/the-button-element/command-and-commandfor/on-dialog-behavior.tentative.html [wpt.fyi]
    • invoking (with command property as show-modal) closed dialog opens as modal: FAIL (Safari: FAIL)
    • invoking (with command property as show-modal) while changing command still opens as modal: FAIL (Safari: FAIL)
    • invoking (with command attribute as show-modal) closed dialog opens as modal: FAIL (Safari: FAIL)
    • invoking (with command attribute as show-modal) while changing command still opens as modal: FAIL (Safari: FAIL)
    • invoking (with command property as sHoW-mOdAl) closed dialog opens as modal: FAIL (Safari: FAIL)
    • invoking (with command property as sHoW-mOdAl) while changing command still opens as modal: FAIL (Safari: FAIL)
    • invoking (with command attribute as sHoW-mOdAl) closed dialog opens as modal: FAIL (Safari: FAIL)
    • invoking (with command attribute as sHoW-mOdAl) while changing command still opens as modal: FAIL (Safari: FAIL)
    • invoking to close (with command property as close) open dialog closes: FAIL (Safari: FAIL)
    • invoking to close (with command property as close) open dialog closes and sets returnValue: FAIL (Safari: FAIL)
    • invoking to close (with command property as close) open dialog while changing command still closes: FAIL (Safari: FAIL)
    • invoking to close (with command property as close) open modal dialog while changing command still closes: FAIL (Safari: FAIL)
    • invoking to close (with command attribute as close) open dialog closes: FAIL (Safari: FAIL)
    • invoking to close (with command attribute as close) open dialog closes and sets returnValue: FAIL (Safari: FAIL)
    • invoking to close (with command attribute as close) open dialog while changing command still closes: FAIL (Safari: FAIL)
    • invoking to close (with command attribute as close) open modal dialog while changing command still closes: FAIL (Safari: FAIL)
    • invoking to close (with command property as cLoSe) open dialog closes: FAIL (Safari: FAIL)
    • invoking to close (with command property as cLoSe) open dialog closes and sets returnValue: FAIL (Safari: FAIL)
    • invoking to close (with command property as cLoSe) open dialog while changing command still closes: FAIL (Safari: FAIL)
    • invoking to close (with command property as cLoSe) open modal dialog while changing command still closes: FAIL (Safari: FAIL)
    • invoking to close (with command attribute as cLoSe) open dialog closes: FAIL (Safari: FAIL)
    • invoking to close (with command attribute as cLoSe) open dialog closes and sets returnValue: FAIL (Safari: FAIL)
    • invoking to close (with command attribute as cLoSe) open dialog while changing command still closes: FAIL (Safari: FAIL)
    • invoking to close (with command attribute as cLoSe) open modal dialog while changing command still closes: FAIL (Safari: FAIL)
    • invoking (as show-modal) closed popover dialog opens as modal: FAIL (Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f096066e9a5b [wpt PR 50457] - Add new request-close command for dialogs, a=testonly https://hg.mozilla.org/integration/autoland/rev/0b16770d0296 [wpt PR 50457] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
You need to log in before you can comment on or make changes to this bug.