Closed Bug 1945609 Opened 11 days ago Closed 9 days ago

Update xsimd to new version 6d6067a049987803ae07dad62f66f603773324b9 from 2025-01-26 21:05:43

Categories

(Core :: Performance, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
137 Branch
Tracking Status
firefox137 --- fixed

People

(Reporter: update-bot, Assigned: padenot)

Details

(Whiteboard: [3pl-filed][task_id: N5A-Qkv8Sr6CTMLGxvpkVA])

Attachments

(1 file)

This update covers 4 commits. Here are the overall diff statistics, and then the commit information.


third_party/xsimd/include/xsimd/arch/xsimd_sse2.hpp | 25 ++++++++++
third_party/xsimd/include/xsimd/memory/xsimd_aligned_allocator.hpp | 2 +-
third_party/xsimd/include/xsimd/types/xsimd_avx2_register.hpp | 5 ++
third_party/xsimd/include/xsimd/types/xsimd_avx512bw_register.hpp | 4 +
third_party/xsimd/include/xsimd/types/xsimd_avx512cd_register.hpp | 4 +
third_party/xsimd/include/xsimd/types/xsimd_avx512dq_register.hpp | 4 +
third_party/xsimd/include/xsimd/types/xsimd_avx512er_register.hpp | 4 +
third_party/xsimd/include/xsimd/types/xsimd_avx512f_register.hpp | 4 +
third_party/xsimd/include/xsimd/types/xsimd_avx512ifma_register.hpp | 4 +
third_party/xsimd/include/xsimd/types/xsimd_avx512pf_register.hpp | 4 +
third_party/xsimd/include/xsimd/types/xsimd_avx512vbmi_register.hpp | 4 +
third_party/xsimd/include/xsimd/types/xsimd_avx512vnni_avx512bw_register.hpp | 4 +
third_party/xsimd/include/xsimd/types/xsimd_avx512vnni_avx512vbmi_register.hpp | 4 +
third_party/xsimd/include/xsimd/types/xsimd_avx_register.hpp | 4 +
third_party/xsimd/include/xsimd/types/xsimd_avxvnni_register.hpp | 5 ++
third_party/xsimd/include/xsimd/types/xsimd_fma3_avx2_register.hpp | 5 ++
third_party/xsimd/include/xsimd/types/xsimd_fma3_avx_register.hpp | 5 ++
third_party/xsimd/include/xsimd/types/xsimd_fma3_sse_register.hpp | 5 ++
third_party/xsimd/include/xsimd/types/xsimd_fma4_register.hpp | 5 ++
third_party/xsimd/include/xsimd/types/xsimd_i8mm_neon64_register.hpp | 5 ++
third_party/xsimd/include/xsimd/types/xsimd_neon64_register.hpp | 4 +
third_party/xsimd/include/xsimd/types/xsimd_sse3_register.hpp | 5 ++
third_party/xsimd/include/xsimd/types/xsimd_sse4_1_register.hpp | 5 ++
third_party/xsimd/include/xsimd/types/xsimd_sse4_2_register.hpp | 5 ++
third_party/xsimd/include/xsimd/types/xsimd_ssse3_register.hpp | 5 ++
third_party/xsimd/moz.yaml | 4 +-
26 files changed, 131 insertions(+), 3 deletions(-)


6d6067a049987803ae07dad62f66f603773324b9 by serge-sans-paille <serge.guelton@telecom-bretagne.eu>

https://github.com/QuantStack/xsimd/commit/6d6067a049987803ae07dad62f66f603773324b9
Authored: 2025-01-26 17:23:24 +0100
Committed: 2025-01-26 21:05:43 +0000

Explicitly verify dependency between architectures (like sse3 implies sse2)

Also add CI to make sure the assumption we make are correct on all
architectures supported by GCC.

Fix #1070

Files Added:

  • .github/workflows/arch-consistency-check.yml
  • test/check_arch.sh

Files Modified:

  • include/xsimd/types/xsimd_avx2_register.hpp
  • include/xsimd/types/xsimd_avx512bw_register.hpp
  • include/xsimd/types/xsimd_avx512cd_register.hpp
  • include/xsimd/types/xsimd_avx512dq_register.hpp
  • include/xsimd/types/xsimd_avx512er_register.hpp
  • include/xsimd/types/xsimd_avx512f_register.hpp
  • include/xsimd/types/xsimd_avx512ifma_register.hpp
  • include/xsimd/types/xsimd_avx512pf_register.hpp
  • include/xsimd/types/xsimd_avx512vbmi_register.hpp
  • include/xsimd/types/xsimd_avx512vnni_avx512bw_register.hpp
  • include/xsimd/types/xsimd_avx512vnni_avx512vbmi_register.hpp
  • include/xsimd/types/xsimd_avx_register.hpp
  • include/xsimd/types/xsimd_avxvnni_register.hpp
  • include/xsimd/types/xsimd_fma3_avx2_register.hpp
  • include/xsimd/types/xsimd_fma3_avx_register.hpp
  • include/xsimd/types/xsimd_fma3_sse_register.hpp
  • include/xsimd/types/xsimd_fma4_register.hpp
  • include/xsimd/types/xsimd_i8mm_neon64_register.hpp
  • include/xsimd/types/xsimd_neon64_register.hpp
  • include/xsimd/types/xsimd_sse3_register.hpp
  • include/xsimd/types/xsimd_sse4_1_register.hpp
  • include/xsimd/types/xsimd_sse4_2_register.hpp
  • include/xsimd/types/xsimd_ssse3_register.hpp

4cd58eff7cd0146910f2b7a63ede34592fb67bc3 by serge-sans-paille <serge.guelton@telecom-bretagne.eu>

https://github.com/QuantStack/xsimd/commit/4cd58eff7cd0146910f2b7a63ede34592fb67bc3
Authored: 2025-01-20 22:01:02 +0100
Committed: 2025-01-21 06:32:58 +0000

Use default arch alignment as default alignment for xsimd::aligned_allocator

That way we match the behavior of xsimd::batch.

Files Modified:

  • benchmark/xsimd_benchmark.hpp
  • examples/mandelbrot.cpp
  • include/xsimd/memory/xsimd_aligned_allocator.hpp

e28ef98286a606c0dcb735fee4606e7edbd7a19f by serge-sans-paille <serge.guelton@telecom-bretagne.eu>

https://github.com/QuantStack/xsimd/commit/e28ef98286a606c0dcb735fee4606e7edbd7a19f
Authored: 2025-01-13 09:11:38 +0100
Committed: 2025-01-13 21:21:20 +0000

[ci] Disable clang arm when cross-compiling

It leads to qemu errors while gcc compiles just fine

Files Modified:

  • .github/workflows/cross.yml

d891f624e56356d1f0f858b48857f2070481c822 by serge-sans-paille <serge.guelton@telecom-bretagne.eu>

https://github.com/QuantStack/xsimd/commit/d891f624e56356d1f0f858b48857f2070481c822
Authored: 2025-01-08 19:58:11 +0100
Committed: 2025-01-13 21:21:20 +0000

sse2 version of xsimd::swizzle on [u]int16_t

... and test it, as well as other version.

Files Modified:

  • include/xsimd/arch/xsimd_sse2.hpp
  • test/test_shuffle.cpp

The try push is done, we found jobs with unclassified failures.

Needs Close Investigation:

  • test-linux1804-64-qr/opt-mochitest-plain-ioi - 4 of 4 failed on the same (retriggered) task (failed: TfiobeIPTzORUzxU2pZvBw, BIrtpZHTS0i13ucgR49Ieg, JkRojoCTStKMw_kHxarqGg, VmivLUiZQvqhKr7ZxgQnjQ)

Needs Investigation (Possible Intermittents):

  • test-android-em-7.0-x86_64-qr/debug-isolated-process-geckoview-junit-nofis - 3 of 4 failed on the same (retriggered) task (failed: RS4pjTHqTZ2LozpjJod5-g, FtE--VeuQWi0BgdinaDkNQ, FbLF-bd-SmSVshHAkiQI-g)

Known Issues:

  • browser/components/sessionstore/test/browser_frametree.js
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-2 (UI9r4fEaSlKMr4u0mUwytw)

  • browser/components/sidebar/tests/browser/browser_glean_sidebar.js
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-3 (AE4qGpptQO6a0IaONETn3Q)

  • toolkit/components/pictureinpicture/tests/browser_thirdPartyIframe.js
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-8 (fsX5EnoITMmPLyxW7Km0Fw)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor third_party/xsimd/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Assignee: nobody → padenot
Flags: needinfo?(padenot)
Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/be1861fd6e86 Update xsimd to 6d6067a049987803ae07dad62f66f603773324b9 r=padenot
Flags: needinfo?(padenot)
Status: NEW → RESOLVED
Closed: 9 days ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: