194567 - [Mac, classic] Thread pane junk icon is cropped

Status: REOPENED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

[classic] thread pane junk icon is cropped

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

this might be an icon issue, or a css issue

Comment 2

[timeless]

just use the trash can icon. I did it for newclassic
http://bugzilla.mozilla.org/show_bug.cgi?id=newclassic
imo it's actually a better fit in thread pane than the icon you have.

historically classic art is 3d, the icon you're using isn't, as such the trash
can icon from modern is somewhat 3d and just feels better.

note that newclassic has a few mailnews skin patches, but i can't figure out how
to get approval for them so i'm not spending any time on it.

Comment 3

[gail]

This is not an icon issue as the TP header icon *is* being displayed correctly,
and the icon within the column also is being drawn at the true aspect ratio. 

The one in the column, however, is offset by 1 px and at the same time is
cropped at right by 1 px.

Comment 4

[(not reading, please use [e-mail] instead)]

...or might be a tree painting issue.  I haven't debugged yet.

jan, our tree wizard, can you take a look?

Comment 5

[timeless]

it's a css paddding/margin thing, just diff through newclassic and take what you
need.

Comment 6

[(not reading, please use [e-mail] instead)]

if it is css, shuehan can you take a look?

Comment 7

[shliang]

Attachment: patch

Comment 8

[shliang]

Comment on attachment 121921 [details] [diff] [review]
patch

oh wait, i thought the bug was about the treeheader. nevermind

Comment 9

[shliang]

Attachment: patch [Checkin: Comment 14]

Comment 10

[shliang]

Attachment: screenshot

Comment 11

[(not reading, please use [e-mail] instead)]

Comment on attachment 121924 [details] [diff] [review]
patch
[Checkin: Comment 14]

r/sr/a=sspitzer

thanks shuehan.

Comment 12

[Jan Varga [:janv]]

-> shuehan
thanks

Comment 13

[Samir Gehani]

Is this fixed?

Comment 14

[shliang]

resolving

Comment 15

[esther]

Using trunk build 20030508 on winxp and linux this is fixed.  But for Mac OSX
the column needs a little more space to the right. The icon is not cut off in
the column header but in the column of the thread pane.  Reopening and
nominating, this is the default theme for Mac. Note I tested this in 2
resolutions 1024x768 and 1152x870   
Changing summary to say MAC only and os to Mac

Comment 16

[Wayne Mery (:wsmwk)]

(In reply to comment #15)
> ... for Mac OSX the column needs a little more space to the right.  

Comment 17

[Stefan [:stefanh]]

Hmm, what if we just made the icon for the thread pane smaller and nuked the style rules that were added with attachment #121924 [details] [diff] [review]? 

Comment 18

[Stefan [:stefanh]]

Attachment: Use left/right padding on junkStatusHeader etc

This fixes the problem. Not tested on win/nix :-/

Comment 19

[Karsten Düsterloh]

Comment on attachment 216248 [details] [diff] [review]
Use left/right padding on junkStatusHeader etc

Well, I don't see what gets better here - neither column header nor cell icon was cut before for me. And after applying the patch, they still aren't aligned vertically and the column header icon is squashed...
Can you attach screenshots of what you're trying to fix and how it does look for you after this patch?

Comment 20

[Stefan [:stefanh]]

Attachment: screenshots

> Can you attach screenshots of what you're trying to fix and how it does look
> for you after this patch?

Sure. I've forgotten about this patch - should probably do something about the other column as well. Anyway, look at the junk mail icon (non-patched vs patched).   You don't see the same on mac? In that case I should probably clean up my tree :-/

Comment 21

[Serge Gautherie (:sgautherie)]

Stefan,
Are you still working on this ?

Comment 22

[Stefan [:stefanh]]

(In reply to comment #21)
> Stefan,
> Are you still working on this ?

I have to check if this is still an issue. Does the patch still applies? Is comment #19 still true?

Comment 23

[Serge Gautherie (:sgautherie)]

(In reply to comment #22)
> I have to check if this is still an issue.

(Yes.)

> Does the patch still applies?

No: (on trunk...)

New file location is
</suite/themes/classic/messenger/threadPane.css>

"1.23	neil%parkwaycc.co.uk	2007-09-06 14:47	 	Manuel Reimer's new message window icons CSS changes b=348720 r+sr=me"
removed |margin-right: -1px;|

> Is comment #19 still true?

(I don't know. Karsten ?)