The “Save to Pocket”, “Archive in Pocket” and “Delete from Pocket” context menu items are still displayed while the Pocket extension is disabled and grid cards layout is enabled
Categories
(Firefox :: New Tab Page, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr115 | --- | unaffected |
firefox-esr128 | --- | unaffected |
firefox135 | --- | unaffected |
firefox136 | + | affected |
firefox137 | + | fixed |
People
(Reporter: srosu, Assigned: thecount)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(2 files)
[Affected versions]:
- Firefox Nightly 137.0a1 (Build ID: 20250203211456)
- Firefox Beta 136.0b1 (Build ID: 20250204012944)
- Firefox Release 135.0 (Build ID: 20250130195129)
[Affected Platforms]:
- Windows 10 x64
- macOS 14.7.1
- Ubuntu 24.04 x64
[Prerequisites]:
- Have the latest version of the Firefox Nightly 137.0a1 build installed/extracted.
- Have the Pocket extension disabled (
extensions.pocket.enabled
pref set tofalse
in the “about:config page). - Have the
browser.search.region
pref set toUS
in the “about:config” page.
[Steps to reproduce]:
- Open the browser with the profile from thre prerequisites and open a new tab.
- Hover any non-sponsored card.
- Click the contextual menu button from the top right part of the card.
- Observe the options displayed.
[Expected result]:
- The “Save to Pocket” option is not displayed.
[Actual result]:
- The “Save to Pocket” context menu item is displayed.
[Regression Window]:
- The issue is not reproducible with older Nightly 136.0a1 builds. Considering this using mozregression tools I have found the regression range. Here are the results:
Last good revision: ab0b1bfb4d28e723e46162f69ee996165c01a68d
First bad revision: 4ca836f09653c66a2b299c4d1607dc5d6aaf97b4
Pushlog: link
From this pushlog it seems that Bug 1944185 may have introduced this behavior.
[Notes]:
- This issue is also reproducible with the “Archive in Pocket” and “Delete from Pocket” context menu items.
- Attached is a screenshot of the issue.
Reporter | ||
Updated•6 days ago
|
Comment 1•6 days ago
|
||
:thecount, since you are the author of the regressor, bug 1944185, could you take a look?
For more information, please visit BugBot documentation.
Reporter | ||
Updated•6 days ago
|
Updated•6 days ago
|
Comment 2•3 days ago
|
||
This is present in 135, correct? If so, it likely wasn't introduced by https://bugzilla.mozilla.org/show_bug.cgi?id=1944185, as that was in 136.
Comment 3•3 days ago
|
||
Tracking for Fx136 since this is mentioned in the QA sign-off.
"Remove "Save to Pocket" button - Beta 136 QA preliminary status (YELLOW)"
:srosu could you confirm if Fx135 is affected? As mentioned in Comment 2 the regressor is only in Fx136+
Reporter | ||
Comment 4•3 days ago
•
|
||
Hi, Donal! I confirm that the issue is also reproducible in Fx135 Release (Build ID: 20250130195129). I will also try to find a new regression window.
Comment 5•3 days ago
|
||
Thanks :srosu, there must be a different regressor so. Bug 1944185 is not in Fx135.
:thecount already has a need-info and is likey within the team anyway.
In the meantime, it would be good to narrow down the correct regressor.
Assignee | ||
Comment 6•3 days ago
•
|
||
I think the bug 1944185 is likely the correct regressor because it is a pref flip, the reason it's also in 135 is we also have a rollout running for it. As a pref flip, it's a bit misleading, but it should be the right regressor.
Either way I'll look into this.
Reporter | ||
Comment 7•3 days ago
|
||
Hi, Donal and Scott! After further investigation, it seems that on Firefox 135 I've hit Bug 1933461 and our issue is reproducible only starting with FX136 as stated in the regression window.
Considering this, I'm changing the status of Firefox 135 to unaffected. Sorry for all the confusion!
Assignee | ||
Comment 8•3 days ago
|
||
Comment 10•2 days ago
|
||
bugherder |
Description
•