Open Bug 1945835 Opened 14 days ago Updated 1 hour ago

Timestamp not displayed for items under "Tabs from other devices" in Firefox View Next tab

Categories

(Firefox :: Firefox View, defect, P2)

Desktop
All
defect

Tracking

()

Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox135 --- wontfix
firefox136 --- wontfix
firefox137 --- affected

People

(Reporter: bhidecuti, Unassigned)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-firefox-view])

Attachments

(1 file)

Attached image ss showing the issue

Found in

  • 136.0b1

Affected versions

  • 137.0a1
  • 136.0b1
  • 135.0

Preconditions

  • FxA account connected to other desktop devices
  • Have a few tabs opened

Tested platforms

  • Affected platforms: Windows 11, macOS 13, Ubuntu 22.04
  • Unaffected platforms: none

Steps to reproduce

  1. Open Firefox View and select the “Tabs from other devices” card
  2. Observe the screen

Expected result

  • The tabs from other devices should display the timestamp

Actual result

  • The tabs from other devices do not display the timestamp

Regression range

Additional notes

  • See the attached screenshot
  • Also reproducing for the “Tabs from other device” section under the “Recent browsing” card
  • A bug was already filled for this -> bug 1940988, but the timestamp issue was not fixed

:skhamis, since you are the author of the regressor, bug 1920852, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(skhamis)

It looks like https://bugzilla.mozilla.org/show_bug.cgi?id=1940988 only fixed the 3 dot menu not showing up for tabs opened on other devices. It looks like we just need to add the time from https://searchfox.org/mozilla-central/source/browser/components/firefoxview/fxview-tab-list.mjs#290 to the synced-tabs-list https://searchfox.org/mozilla-central/source/browser/components/firefoxview/syncedtabs-tab-list.mjs#129. Looks like we also already have the time variable via the controller https://searchfox.org/mozilla-central/source/browser/components/firefoxview/SyncedTabsController.sys.mjs#318 so this should be a relatively straightforward to pipe the time through. Though I imagine there's some snazzy formatting for the time format and whatnot.

I don't have bandwidth currently but hopefully the above should be enough to guide someone on the FxView team. If not, let me know!

Severity: -- → S3
Flags: needinfo?(skhamis)
Priority: -- → P1
Whiteboard: [fidefe-firefox-view]
Priority: P1 → P2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: