Timestamp not displayed for items under "Tabs from other devices" in Firefox View Next tab
Categories
(Firefox :: Firefox View, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr115 | --- | unaffected |
firefox-esr128 | --- | unaffected |
firefox135 | --- | wontfix |
firefox136 | --- | wontfix |
firefox137 | --- | affected |
People
(Reporter: bhidecuti, Unassigned)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [fidefe-firefox-view])
Attachments
(1 file)
429.09 KB,
image/png
|
Details |
Found in
- 136.0b1
Affected versions
- 137.0a1
- 136.0b1
- 135.0
Preconditions
- FxA account connected to other desktop devices
- Have a few tabs opened
Tested platforms
- Affected platforms: Windows 11, macOS 13, Ubuntu 22.04
- Unaffected platforms: none
Steps to reproduce
- Open Firefox View and select the “Tabs from other devices” card
- Observe the screen
Expected result
- The tabs from other devices should display the timestamp
Actual result
- The tabs from other devices do not display the timestamp
Regression range
- Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6d1113bb77a8bd300a5136c427d49bd55c64902f&tochange=a588c633d90bfaaff39863cf6ab534dc0bac5ea7
- Potentially regressed by: Bug 1920852. Please feel free to change the regressor if it is not the correct one
Additional notes
- See the attached screenshot
- Also reproducing for the “Tabs from other device” section under the “Recent browsing” card
- A bug was already filled for this -> bug 1940988, but the timestamp issue was not fixed
Comment 1•14 days ago
|
||
:skhamis, since you are the author of the regressor, bug 1920852, could you take a look? Also, could you set the severity field?
For more information, please visit BugBot documentation.
Updated•8 days ago
|
Comment 2•8 days ago
|
||
It looks like https://bugzilla.mozilla.org/show_bug.cgi?id=1940988 only fixed the 3 dot menu not showing up for tabs opened on other devices
. It looks like we just need to add the time
from https://searchfox.org/mozilla-central/source/browser/components/firefoxview/fxview-tab-list.mjs#290 to the synced-tabs-list https://searchfox.org/mozilla-central/source/browser/components/firefoxview/syncedtabs-tab-list.mjs#129. Looks like we also already have the time variable via the controller https://searchfox.org/mozilla-central/source/browser/components/firefoxview/SyncedTabsController.sys.mjs#318 so this should be a relatively straightforward to pipe the time through. Though I imagine there's some snazzy formatting for the time format and whatnot.
I don't have bandwidth currently but hopefully the above should be enough to guide someone on the FxView team. If not, let me know!
Updated•8 days ago
|
Updated•8 days ago
|
Updated•6 days ago
|
Updated•1 hour ago
|
Description
•