Please update Herald rule for "extension-reviewers" group to exempt browser/extensions/newtab
Categories
(Conduit :: Phabricator, task)
Tracking
(Not tracked)
People
(Reporter: mconley, Assigned: dkl)
Details
We [recently moved] most of the New Tab codebase to browser/extensions/newtab in bug 1938452.
This is in preparation of modifying New Tab to be packaged as a built-in addon. For now though, it's not a built-in addon.
The existing Herald rule for the extension-reviewers group appears to be matching on changes under browser/extensions/newtab, and we probably don't want that - that's going to add a lot of extra reviews for the WebExtensions team for code they probably don't care about, and add a whole new barrier to landing patches for the New Tab team.
For now, I've instructed the New Tab team to manually remove the extensions-reviewers group being added as blocking reviewers, but I'm hoping we can update the Herald rule instead. Can we exempt browser/extensions/newtab from adding extension-reviewers as a blocking reviewer group?
|
Reporter | |
Updated•1 year ago
|
|
||
Comment 1•1 year ago
|
||
The fact that we match any new thing in browser/extensions/ is intended.
For newtab, the extension-reviewers group doesn't need to be added as a blocking reviewer group. We do exclude some of the built-in/system add-ons in our Herald rule already IIRC.
|
Assignee | |
Comment 2•1 year ago
|
||
I updated the current regex to exclude newtab from matching:
Affected files matches regexp @^/?((browser|toolkit|mobile/shared)/components|toolkit/mozapps)/extensions|^/?browser/extensions/(?!formautofill|pictureinpicture|report-site-issue|screenshots|webcompat|newtab)@
|
|
Reporter | |
Comment 3•1 year ago
|
||
Thanks so much!
Description
•