Open Bug 1945927 Opened 3 days ago Updated 1 day ago

Resizing the sidebar is broken after toggling sidebar on and off

Categories

(Firefox :: Sidebar, defect, P1)

defect

Tracking

()

ASSIGNED
Tracking Status
firefox-esr128 --- unaffected
firefox135 --- affected
firefox136 --- affected
firefox137 --- affected

People

(Reporter: muffinresearch, Assigned: jsudiaman, NeedInfo)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-sidebar])

Attachments

(2 files)

STR:

  • With a new profile enable sidebar and vertical tabs (from either Fx Labs or about:preferences).
  • Expand the sidebar with the sidebar button (note you can resize the vertical tabs area)
  • Turn off sidebar (which disables vertical tabs)
  • Reenable the sidebar and vertical tabs and expand the vertical tabs

What happens:

The resizing of the sidebar now snaps to the original position it was in and you can't resize the sidebar.

What should happen:

Resizing the vertical tabs area should still function

From running mozregression this appears to have been regressed by bug 1930199

Note: the screencast also shows another bug (hiding first before expanding, that's covered elsewhere so can be ignored for the purposes of this bug).

Set release status flags based on info from the regressing bug 1930199

:jsudiaman, since you are the author of the regressor, bug 1930199, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(jsudiaman)
Assignee: nobody → jsudiaman
Status: NEW → ASSIGNED
Flags: needinfo?(jsudiaman)
Priority: -- → P1
Severity: -- → S3
Blocks: 1946188
Pushed by jsudiaman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cef2da85ff94 Ensure that resize observer is restored when reinitializing revamped sidebar. r=sidebar-reviewers,kcochrane

Backed out for causing bc failures @ browser_glean_sidebar.js

TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Two events were reported. - 3 == 2 -
Flags: needinfo?(jsudiaman)
Pushed by jsudiaman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ff0ae341ed38 Ensure that resize observer is restored when reinitializing revamped sidebar. r=sidebar-reviewers,kcochrane

Backed out for causing bc failures @browser_customize_sidebar.js

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: