Hide the sidebar launcher splitter when vertical tabs is disabled.
Categories
(Firefox :: Sidebar, defect, P1)
Tracking
()
People
(Reporter: nsharpley, Assigned: kcochrane)
References
(Regressed 1 open bug)
Details
(Whiteboard: [fidefe-sidebar])
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
dmeehan
:
approval-mozilla-beta+
|
Details | Review |
Now that we don't allow for expanding the sidebar main element in horizontal tabs mode, we can hide the splitter element.
Updated•9 days ago
|
Assignee | ||
Updated•9 days ago
|
Assignee | ||
Updated•9 days ago
|
Assignee | ||
Comment 1•9 days ago
•
|
||
(In reply to Nikki Sharpley (:nikkis) (she/her) from comment #0)
Now that we don't allow for expanding the sidebar main element in horizontal tabs mode, we can hide the splitter element.
Noting that this should only apply to the sidebar launcher splitter and not the sidebar panel splitter. We removed the ability to resize the launcher when horizontal tabs are enabled in bug 1938249.
Assignee | ||
Comment 2•9 days ago
|
||
Updated•8 days ago
|
Comment 4•8 days ago
|
||
bugherder |
Assignee | ||
Comment 5•7 days ago
|
||
Comment on attachment 9463899 [details]
Bug 1945930 - Hide sidebar launcher splitter when sidebar.revamp is true and sidebar.verticalTabs is false
Beta/Release Uplift Approval Request
- User impact if declined/Reason for urgency: Users using the new sidebar with horizontals tabs will see a launcher splitter that doesn't actually resize the sidebar launcher
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Enable the new sidebar either in about:preferences or about:config (
sidebar.revamp
). Make sure the launcher area of the sidebar (that shows tool buttons and extensions) no longer shows a splitter on the right hand side. Note that the sidebar panel will still have a splitter. - List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Very small css change to conditionally hide the splitter
- String changes made/needed:
- Is Android affected?: No
Assignee | ||
Updated•7 days ago
|
Comment 6•7 days ago
|
||
Holding off on uplifting for now until the regressor Bug 1946263 has been fixed.
This is just to avoid noise in beta.
Updated•6 days ago
|
Reproduced the issue with Firefox 136.0b2 on Windows 10x64. When using horizontal tabs there is a splitter on the sidebar that does not resize the sidebar.
The issue has been verified fixed with Firefox 137.0a1 (2025-02-07) on Windows 10x64, macOS 12, and Ubuntu 24. The resize splitter is no longer present when hovering on the right side of the sidebar with horizontal tabs. The sidebar panel can still be resized.
Comment 8•1 day ago
|
||
(In reply to Donal Meehan [:dmeehan] from comment #6)
Holding off on uplifting for now until the regressor Bug 1946263 has been fixed.
This is just to avoid noise in beta.
Bug 1946263 is pointing to bug 1946188 as potentially fixing a test issue (which we can request uplift on) but we really need to get this patch uplifted as we have 6 other patches needing uplift and we're nearing the end of early beta. Could you uplift this please and we can help with any intermittents as needed?
Comment 9•1 day ago
|
||
(In reply to Sarah Clements [:sclements] from comment #8)
(In reply to Donal Meehan [:dmeehan] from comment #6)
Holding off on uplifting for now until the regressor Bug 1946263 has been fixed.
This is just to avoid noise in beta.Bug 1946263 is pointing to bug 1946188 as potentially fixing a test issue (which we can request uplift on) but we really need to get this patch uplifted as we have 6 other patches needing uplift and we're nearing the end of early beta. Could you uplift this please and we can help with any intermittents as needed?
Sure I can uplift this for 136.0b6. Appreciate the follow-up on getting fixes/requests on the intermittents.
Comment 10•1 day ago
|
||
Comment on attachment 9463899 [details]
Bug 1945930 - Hide sidebar launcher splitter when sidebar.revamp is true and sidebar.verticalTabs is false
Approved for 136.0b6
Comment 11•1 day ago
|
||
uplift |
Updated•1 day ago
|
Description
•