1946016 - The window of a detached tab is larger than the original

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[tgn-ff]

Steps to reproduce:

1. Open a window with two tabs.
2. Drag one of the tabs and create a new window.

This was tested on KDE/X11.

Actual results:

The new window ends up being larger than the original.

Expected results:

Regressed by 581863.

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ff5432cc7e7c0d223330a7c8f09a89d797793f83&tochange=9efb94e533503b0cd1309c16d01d488a69941059

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 581863, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1946016 - Don't be explicit about window size when detaching tabs on Linux. r=dao

Let Gecko choose a suitable size. This seems to result in the desired
behavior (same as Ctrl+N). Tested GNOME and Kwin, X11 and Wayland.

The reason for the behavior change here is because outerWidth before
the regressing patch returned the inner, not the outer width. Combined
with the pre-existing behavior that decorations are added asynchronously
by the window manager, it just happened to conveniently cancel out that
bug, which is now fixed.

It's unclear we need this at all on macOS fwiw. IIRC Cmd+N does also the
same thing as Windows, so maybe we can remove this block altogether.

Separate patch tho, as I don't have a macOS build ready to test it this
very moment, but I think it should just work.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1946016 - Remove macOS special case too. r=dao

Just tested, doesn't change behavior.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbbe4e0b455e
Don't be explicit about window size when detaching tabs on Linux. r=dao,tabbrowser-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4eb870204239
Remove macOS special case too. r=dao,tabbrowser-reviewers

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/dbbe4e0b455e
https://hg.mozilla.org/mozilla-central/rev/4eb870204239