1946086 - Support three operand shift/bitwise operations when one operand is an immediate

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[André Bargull [:anba]]

Support three operand shift/bitwise operations to replace:

masm.move32(src, dest);
masm.rshift32(Imm32(n), dest);

with:

masm.rshift32(Imm32(n), src, dest);

This helps to avoid a register move for non-x86/x64 targets.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1946086 - Part 1: Add three-operand shift operations. r=jandem!

Part 2 will update code to use the three-operand functions.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1946086 - Part 2: Use three-operand shift instructions. r=jandem!

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1946086 - Part 3: Add three-operand bitwise operations. r=jandem!

Part 4 will update code to use the three-operand functions.

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1946086 - Part 4: Use three-operand bitwise instructions. r=jandem!

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1946086 - Part 5: Use three-operand add instruction. r=jandem!

Use the existing three operand method in two places.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfe5282ff253
Part 1: Add three-operand shift operations. r=jandem
https://hg.mozilla.org/integration/autoland/rev/299fa59e05df
Part 2: Use three-operand shift instructions. r=jandem
https://hg.mozilla.org/integration/autoland/rev/fa847db27e7b
Part 3: Add three-operand bitwise operations. r=jandem
https://hg.mozilla.org/integration/autoland/rev/bc8e264aecbd
Part 4: Use three-operand bitwise instructions. r=jandem
https://hg.mozilla.org/integration/autoland/rev/caf217a2262f
Part 5: Use three-operand add instruction. r=jandem

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/dfe5282ff253
https://hg.mozilla.org/mozilla-central/rev/299fa59e05df
https://hg.mozilla.org/mozilla-central/rev/fa847db27e7b
https://hg.mozilla.org/mozilla-central/rev/bc8e264aecbd
https://hg.mozilla.org/mozilla-central/rev/caf217a2262f