1946102 - Perma [tier 2] devtools/client/inspector/rules/test/browser_rules_computed-lists_02.js | Node is not accessible via accessibility API: id: , tagName: span, className: ruleview-expander theme-twisty -

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: sstanca [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=493406446&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/DcKK4My_TxGgTjI9pn9Qog/runs/0/artifacts/public/logs/live_backing.log

---

[task 2025-02-05T12:32:14.588Z] 12:32:14     INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_computed-lists_02.js | margin computed list is closed - 
[task 2025-02-05T12:32:14.588Z] 12:32:14     INFO - Opening the computed list of margin property
[task 2025-02-05T12:32:14.589Z] 12:32:14     INFO - Buffered messages finished
[task 2025-02-05T12:32:14.590Z] 12:32:14     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_computed-lists_02.js | Node is not accessible via accessibility API: id: , tagName: span, className: ruleview-expander theme-twisty - 
[task 2025-02-05T12:32:14.591Z] 12:32:14     INFO - Stack trace:
[task 2025-02-05T12:32:14.591Z] 12:32:14     INFO - chrome://mochikit/content/browser-test.js:test_ok:1599
[task 2025-02-05T12:32:14.591Z] 12:32:14     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:756
[task 2025-02-05T12:32:14.592Z] 12:32:14     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:1165
[task 2025-02-05T12:32:14.592Z] 12:32:14     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:1141
[task 2025-02-05T12:32:14.592Z] 12:32:14     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleEvent:1258
[task 2025-02-05T12:32:14.592Z] 12:32:14     INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/browser_rules_computed-lists_02.js:testComputedList:34
[task 2025-02-05T12:32:14.592Z] 12:32:14     INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/browser_rules_computed-lists_02.js:null:23
[task 2025-02-05T12:32:14.592Z] 12:32:14     INFO - chrome://mochikit/content/browser-test.js:handleTask:1147
[task 2025-02-05T12:32:14.592Z] 12:32:14     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1219
[task 2025-02-05T12:32:14.592Z] 12:32:14     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1360
[task 2025-02-05T12:32:14.592Z] 12:32:14     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1136
[task 2025-02-05T12:32:14.592Z] 12:32:14     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-02-05T12:32:14.592Z] 12:32:14     INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_computed-lists_02.js | margin computed list is open - 

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:xpresskaran98, since you are the author of the regressor, bug 1564329, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1564329

Comment 3

[Intermittent Failures Robot]

Summary

19 failures in 695 pushes (0.027 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 19

Platform and build breakdown:

• linux1804-64-qr: 19
  • opt: 19

Table

	a11y-checks
linux1804-64-qr--/opt	19

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1946102&startday=2025-02-05&endday=2025-02-05&tree=all

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Bug 1564329 only highlights an existing issue, as the clicked element isn't indeed accessible.
Before, the accessibility check wasn't done because at the time we were its click method, the element wasn't yet added to the page or at least wasn't laid out properly, and the accessibility check task was bailing out because the element had a 0×0 size https://searchfox.org/mozilla-release/rev/21df1ac521242be96e0c070aa713ccff03e1b2d3/testing/mochitest/tests/SimpleTest/AccessibilityUtils.js#1247-1256

const bounds =
  composedTarget.ownerGlobal?.windowUtils?.getBoundsWithoutFlushing(
    composedTarget
  );
if (bounds && (bounds.width == 0 || bounds.height == 0)) {
  // Some tests click hidden nodes. These clearly aren't testing the UI
  // for the node itself (and presumably there is a test somewhere else
  // that does). Therefore, we can't (and shouldn't) do a11y checks.
  return;
}

This changed because we added container: search-container / inline-size to #inspector-search, and for some reason, it must trigger a layout faster, which makes the a11y check actually reveal the issue.
Another test was skipped because of this element https://searchfox.org/mozilla-release/rev/21df1ac521242be96e0c070aa713ccff03e1b2d3/devtools/client/inspector/rules/test/browser_part1.toml#213

skip-if = ["a11y_checks"] # Bugs 1849028 and 1858041 clicked span.ruleview-expander.theme-twisty is inconsistently not accessible

and here it looks like we can add a fail-if since it perma fails

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1946102 - [devtools] Add fail-if=a11y_checks for rules view tests. r=#devtools.

In Bug 1564329 we added a container property to the inspector search element
which seems to trigger an earlier layout than before. This caused some "new"
accessibility checks failures, as before, some elements would have a 0x0 size and
would be explicitely ignored by the a11y checks (https://searchfox.org/mozilla-release/rev/21df1ac521242be96e0c070aa713ccff03e1b2d3/devtools/client/inspector/rules/test/browser_part1.toml#213)

The short-hand toggle button that is clicked is indeed not accessible and the
test is expected to fail the a11y checks.
Turn skip-if annotation of browser_rules_edit-property-computed.js into fail-if
as the failure is now more consistent.

Another failure was found in browser_rules_editable-field-focus_01.js where
we click on the element rule selector to ensure it goes through and adds
a declaration. For this test, we can specifically disable the check as the
selector itself shouldn't be a button, we're just checking that the click is
going through it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66f855d4df5f
[devtools] Add fail-if=a11y_checks for rules view tests. r=devtools-reviewers,bomsy,jdescottes.

Comment 8

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/66f855d4df5f

Comment 9

[Intermittent Failures Robot]

Summary

52 failures in 4309 pushes (0.012 failures/push) were associated with this bug in the last 7 days.

This is the #30 most frequent failure this week.

This failure happened more than 30 times this week! Resolving this bug is a high priority.

Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled.

Repository breakdown:

• autoland: 49
• mozilla-central: 3

Platform and build breakdown:

• linux1804-64-qr: 52
  • opt: 52

Table

	a11y-checks
linux1804-64-qr--/opt	52

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1946102&startday=2025-02-03&endday=2025-02-09&tree=all