Closed Bug 1946116 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 50510 - CSS corner-shape initial parsing

Tracking

()

Status:

RESOLVED FIXED

Milestone:

137 Branch

Tracking Flags:

Tracking

Status

firefox137

---

fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

2 months ago

Sync web-platform-tests PR 50510 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50510
Details from upstream follow.

Noam Rosenthal <nrosenthal@chromium.org> wrote:

CSS corner-shape initial parsing

See https://drafts.csswg.org/css-borders-4/#corner-shaping

This adds the flag, property definition (logical+physical), and
parsing a couple of the keywords.

It also adds the Superellipse style type for storage.

Note that the changes to the corner-shape syntax affect existing
WPTs, which don't currently pass in any browser.

ChromeStatus: https://chromestatus.com/feature/5357329815699456
I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/UKLLVghiHYQ/m/tv0ANlToEQAJ
Bug: 393145930
Change-Id: Ie31440e97f75f42dd4c8129cb34f6f0685884374
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6225742
Commit-Queue: Noam Rosenthal \<nrosenthal@chromium.org>
Reviewed-by: Fredrik Söderquist \<fs@opera.com>
Cr-Commit-Position: refs/heads/main@{#1416146}

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 months ago

Component: web-platform-tests → CSS Parsing and Computation

Product: Testing → Core

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

2 months ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c26e2466e1e200b8b2c201152a42cb707bc2bc0

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

2 months ago

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 96 subtests

Status Summary

Firefox

OK : 2
PASS: 5
FAIL: 96

Chrome

OK : 2
PASS: 5
FAIL: 96

Safari

OK : 2
PASS: 5
FAIL: 96

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-borders/tentative/parsing/corner-shape-valid.html [wpt.fyi]
- e.style['corner-top-left-shape'] = "round" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-left-shape'] = "scoop" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-left-shape'] = "notch" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-left-shape'] = "bevel" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-left-shape'] = "squircle" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-left-shape'] = "straight" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-left-shape'] = "superellipse(2)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-left-shape'] = "superellipse(.5)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-left-shape'] = "superellipse(7)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-left-shape'] = "superellipse(0.3)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-left-shape'] = "superellipse(infinity)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-left-shape'] = "superellipse(calc(0.5 * 4))" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-right-shape'] = "round" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-right-shape'] = "scoop" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-right-shape'] = "notch" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-right-shape'] = "bevel" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-right-shape'] = "squircle" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-right-shape'] = "straight" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-right-shape'] = "superellipse(2)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-right-shape'] = "superellipse(.5)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-right-shape'] = "superellipse(7)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-right-shape'] = "superellipse(0.3)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-right-shape'] = "superellipse(infinity)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-top-right-shape'] = "superellipse(calc(0.5 * 4))" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-left-shape'] = "round" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-left-shape'] = "scoop" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-left-shape'] = "notch" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-left-shape'] = "bevel" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-left-shape'] = "squircle" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-left-shape'] = "straight" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-left-shape'] = "superellipse(2)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-left-shape'] = "superellipse(.5)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-left-shape'] = "superellipse(7)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-left-shape'] = "superellipse(0.3)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-left-shape'] = "superellipse(infinity)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-left-shape'] = "superellipse(calc(0.5 * 4))" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-right-shape'] = "round" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-right-shape'] = "scoop" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-right-shape'] = "notch" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-right-shape'] = "bevel" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-right-shape'] = "squircle" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-right-shape'] = "straight" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-right-shape'] = "superellipse(2)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-right-shape'] = "superellipse(.5)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-right-shape'] = "superellipse(7)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-right-shape'] = "superellipse(0.3)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-right-shape'] = "superellipse(infinity)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-bottom-right-shape'] = "superellipse(calc(0.5 * 4))" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-start-shape'] = "round" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-start-shape'] = "scoop" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-start-shape'] = "notch" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-start-shape'] = "bevel" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-start-shape'] = "squircle" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-start-shape'] = "straight" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-start-shape'] = "superellipse(2)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-start-shape'] = "superellipse(.5)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-start-shape'] = "superellipse(7)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-start-shape'] = "superellipse(0.3)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-start-shape'] = "superellipse(infinity)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-start-shape'] = "superellipse(calc(0.5 * 4))" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-end-shape'] = "round" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-end-shape'] = "scoop" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-end-shape'] = "notch" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-end-shape'] = "bevel" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-end-shape'] = "squircle" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-end-shape'] = "straight" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-end-shape'] = "superellipse(2)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-end-shape'] = "superellipse(.5)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-end-shape'] = "superellipse(7)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-end-shape'] = "superellipse(0.3)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-end-shape'] = "superellipse(infinity)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-start-end-shape'] = "superellipse(calc(0.5 * 4))" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-start-shape'] = "round" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-start-shape'] = "scoop" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-start-shape'] = "notch" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-start-shape'] = "bevel" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-start-shape'] = "squircle" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-start-shape'] = "straight" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-start-shape'] = "superellipse(2)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-start-shape'] = "superellipse(.5)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-start-shape'] = "superellipse(7)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-start-shape'] = "superellipse(0.3)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-start-shape'] = "superellipse(infinity)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-start-shape'] = "superellipse(calc(0.5 * 4))" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-end-shape'] = "round" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-end-shape'] = "scoop" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-end-shape'] = "notch" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-end-shape'] = "bevel" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-end-shape'] = "squircle" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-end-shape'] = "straight" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-end-shape'] = "superellipse(2)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-end-shape'] = "superellipse(.5)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-end-shape'] = "superellipse(7)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-end-shape'] = "superellipse(0.3)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-end-shape'] = "superellipse(infinity)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['corner-end-end-shape'] = "superellipse(calc(0.5 * 4))" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 months ago

Depends on: 1946631

Pulsebot

Comment 3

•

2 months ago

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6a77d3a042f3 [wpt PR 50510] - CSS corner-shape initial parsing, a=testonly https://hg.mozilla.org/integration/autoland/rev/14ae1481b867 [wpt PR 50510] - Update wpt metadata, a=testonly

amarc

Comment 4

•

2 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/6a77d3a042f3
https://hg.mozilla.org/mozilla-central/rev/14ae1481b867

Status: NEW → RESOLVED

Closed: 2 months ago

status-firefox137: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 137 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

[wpt-sync] Sync PR 50510 - CSS corner-shape initial parsing

Categories

(Core :: CSS Parsing and Computation, task, P4)

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Updated

Comment 1

Comment 2

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

Updated

Comment 3

Comment 4