Closed Bug 1946147 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 50511 - [functions] Detect cycles between <dashed-functions>

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
137 Branch
Tracking Flags:
Tracking Status
firefox137 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50511 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50511
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[functions] Detect cycles between <dashed-functions>

This is quite similar to CL:6190327: we just extend CycleElem
to accommodate yet another type.

Unfortunately we won't be able to keep using absl::variable when
we support tree-scoped references, since we'll need to store
GarbageCollected type at that point. But that's a problem for later.

Bug: 325504770
Change-Id: If1a51e5c7ee2d95a7070953c6f72dcf3601ae6a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6190588
Reviewed-by: Munira Tursunova \<moonira@google.com>
Commit-Queue: Anders Hartvoll Ruud \<andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416195}

PR 50511 applied with additional changes from upstream: c5dda19e7580e26e7f5e538af095fdff241c9301, bd0bfff8963e1957454b26ced0555efc381e68b8
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 7 subtests

Status Summary

Firefox

OK : 2
FAIL: 26

Chrome

OK : 2
FAIL: 26

Safari

OK : 2
FAIL: 26

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-mixins/dashed-function-cycles.tentative.html [wpt.fyi]
    • Local with self-cycle: FAIL (Chrome: FAIL, Safari: FAIL)
    • Cycle reference without fallback makes result invalid: FAIL (Chrome: FAIL, Safari: FAIL)
    • Local with self-cycle in fallback: FAIL (Chrome: FAIL, Safari: FAIL)
    • Local shadowing cyclic property --x: FAIL (Chrome: FAIL, Safari: FAIL)
    • Local shadowing cyclic outer local --x : FAIL (Chrome: FAIL, Safari: FAIL)
    • Arguments shadowing cyclic properties: FAIL (Chrome: FAIL, Safari: FAIL)
    • Observing property cycle locally: FAIL (Chrome: FAIL, Safari: FAIL)
    • Using cyclic values with no fallback: FAIL (Chrome: FAIL, Safari: FAIL)
    • Self-cycle in non-used local variable: FAIL (Chrome: FAIL, Safari: FAIL)
    • Using cyclic value in unused fallback: FAIL (Chrome: FAIL, Safari: FAIL)
    • Using cyclic value in unused fallback (local): FAIL (Chrome: FAIL, Safari: FAIL)
    • Dashed-function, self-cycle: FAIL (Chrome: FAIL, Safari: FAIL)
    • Cycle through other function (--g): FAIL (Chrome: FAIL, Safari: FAIL)
    • Cycle through other function (--f): FAIL (Chrome: FAIL, Safari: FAIL)
    • Cycle through local, self: FAIL (Chrome: FAIL, Safari: FAIL)
    • Cycle through unused local: FAIL (Chrome: FAIL, Safari: FAIL)
    • Cycle through global, self: FAIL (Chrome: FAIL, Safari: FAIL)
    • Cycle through local, other function: FAIL (Chrome: FAIL, Safari: FAIL)
    • Cycle through various variables and other functions: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-mixins/local-attr-substitution.html [wpt.fyi]
    • var() in attribute value substitutes locally: FAIL (Chrome: FAIL, Safari: FAIL)
    • var() in attribute value substitutes locally, argument: FAIL (Chrome: FAIL, Safari: FAIL)
    • var() in attribute value substitutes locally, typed: FAIL (Chrome: FAIL, Safari: FAIL)
    • attr() fallback substitutes locally: FAIL (Chrome: FAIL, Safari: FAIL)
    • attr() cycle through local: FAIL (Chrome: FAIL, Safari: FAIL)
    • attr() cycle through fallback in local: FAIL (Chrome: FAIL, Safari: FAIL)
    • attr() cycle through function: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c41ca47b66d4 [wpt PR 50511] - [functions] Detect cycles between <dashed-functions>, a=testonly https://hg.mozilla.org/integration/autoland/rev/01ff8e488653 [wpt PR 50511] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/c41ca47b66d4
https://hg.mozilla.org/mozilla-central/rev/01ff8e488653

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox137: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
You need to log in before you can comment on or make changes to this bug.