1946334 - Prevent buttons in spaces toolbar to be shown twice

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[John Bieling (:TbSync)]

The old spaceButtonToolbar API and the new spaces API both add all registered spaces to the spaces toolbar. If both APIs are used by two different add-ons, all buttons of add-on spaces are shown twice.

Comment 1

[John Bieling (:TbSync)]

Attachment: Bug 1946334 - Prevent buttons in spaces toolbar to be shown twice. r=#thunderbird-reviewers

The old spaceButtonToolbar API and the new spaces API both add all
registered spaces to the spaces toolbar. If both APIs are used by two
different add-ons, all buttons of add-on spaces are shown twice.

This can be observed by installing the two attached add-ons.

Fixed by not adding buttons if they exist already.

Comment 2

[John Bieling (:TbSync)]

Attachment: thirdstats-1.12.0-tb.xpi

Comment 3

[John Bieling (:TbSync)]

Attachment: thunderstats_your_thunderbird_statistics-custom.xpi

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1b2f588724e8
Prevent buttons in spaces toolbar to be shown twice. r=mkmelin