Forwarding binary message produces invalid message



MailNews Core
15 years ago
9 years ago


(Reporter: kaie, Assigned: kaie)




Firefox Tracking Flags

(Not tracked)


(Whiteboard: fixed1.3)


(1 attachment)

729 bytes, patch
Jean-Francois Ducarroz
: review+
(not reading, please use instead)
: superreview+
Details | Diff | Splinter Review


15 years ago
This is a regression introduced with bug 161488.

To reproduce this bug, you need a specially prepared message, that is usually
not produced by mail agents, but is valid (and might be sent by other mail agents).

For example, a message, where the single content is an image.
I can send such a message to anybody who wants to test this behaviour, let me know.

Steps to reproduce:
- receive a message that is (e.g.) of content type image/gif
- forward this message to yourself
- receive the message and look at it

Actual behaviour:
- the received message does not display the image
- when doing view source, raw binary data is displayed

Expected behaviour:
The image should get forwarded as base64 and should display fine when received.

Comment 1

15 years ago
Created attachment 115333 [details] [diff] [review]
Patch v1

This patch appears to fix the problem for me.
I've tested a variety of messages and all seems to be fine.

The idea of the patch is: When doing forwarding as attachment and having
output_format set to Decrypt-Only, when dealing with an mimeExternalObject, do
not allow to decode (be it base64, uue, etc.), but instead pass through the
external object directly.

Comment 2

15 years ago
Comment on attachment 115333 [details] [diff] [review]
Patch v1

Can you please review?
Attachment #115333 - Flags: superreview?(sspitzer)
Attachment #115333 - Flags: review?(ducarroz)


15 years ago
Keywords: regression
Comment on attachment 115333 [details] [diff] [review]
Patch v1

sr=sspitzer, but if he as time (he may not), can you get ducarroz to review?

my only request would be before you check in, please add a comment to the code

// for forwarding binary messages, see bug #194636

(no need for a new patch)
Attachment #115333 - Flags: superreview?(sspitzer) → superreview+
Comment on attachment 115333 [details] [diff] [review]
Patch v1

Attachment #115333 - Flags: review?(ducarroz) → review+
thanks for the review, ducarroz.  (I know you are busy with other things)

Comment 6

15 years ago
Patch checked in, marking fixed.
Last Resolved: 15 years ago
Resolution: --- → FIXED

Comment 7

15 years ago
Comment on attachment 115333 [details] [diff] [review]
Patch v1

Suggesting to fix this regression for the 1.3 release.
Attachment #115333 - Flags: approval1.3?

Comment 8

15 years ago
Comment on attachment 115333 [details] [diff] [review]
Patch v1

a=asa (on brhalf of drivers) for checkin to 1.3 branch. Please land this ASAP
and put fixed1.3 in the status whiteboard. Thanks.
Attachment #115333 - Flags: approval1.3? → approval1.3+

Comment 9

15 years ago
Fix checked in to 1.3 branch.


15 years ago
Whiteboard: fixed1.3
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.