1946425 - [wpt-sync] Sync PR 50526 - [carousel] Don't create ::scroll-marker without ::scroll-marker-group

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50526 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50526
Details from upstream follow.

Daniil Sakhapov <[e-mail]> wrote:

[carousel] Don't create ::scroll-marker without ::scroll-marker-group

As per spec, when ::scroll-marker's nearest ancestor scroll container
scroll container has a computed scroll-marker-group property that is
not none, the pseudo-element generates a box attached as a child of
the ::scroll-marker-group pseudo-element’s generated box on its
nearest ancestor scroll container.

So, we shouldn't create ::scroll-marker without ::scroll-marker-group.
For this, style recalc context will keep track of if there is any
element with scroll-marker-group property.

Fixed: 383552420
Change-Id: I7217f87677d3a6c470056eae8773ba6ae3b4c749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6229916
Reviewed-by: Rune Lillesveen \<[e-mail]>
Commit-Queue: Daniil Sakhapov \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1416737}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5969e4a9ab008b29d5df7600521ee125c997214a

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL : 1

Chrome

CRASH: 1

Safari

OK : 1
FAIL : 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-overflow/target-current-scroll-marker-update.html [wpt.fyi]
  • CSS Test: ::scroll-marker doesn't stay :target-current upon removing scroll-marker-group property: FAIL (Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89e053cc7115
[wpt PR 50526] - [carousel] Don't create ::scroll-marker without ::scroll-marker-group, a=testonly
https://hg.mozilla.org/integration/autoland/rev/0d21e87890c5
[wpt PR 50526] - Update wpt metadata, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/89e053cc7115
https://hg.mozilla.org/mozilla-central/rev/0d21e87890c5