1946517 - Prevent URL bar from showing through preonboarding modal

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Meg Viar [:mviar]]

Attachment: Example of URL bar bleeding through preonboarding Spotlight modal

[Tracking Requested - why for this release]: Supports experimentation in Fx136 (see Jira)

Address issue where URL bar bleeds through preonboarding Spotlight modal after implementation changes in bug 1945672

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1945672

Comment 2

[Meg Viar [:mviar]]

Attachment: Bug 1946517 - Prevent URL bar from showing through preonboarding modal UI

Comment 3

[Chris Peterson [:cpeterson]]

Meg says we should uplift this fix to Beta 136.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox136 (beta). However, the bug still has low severity.

:mviar, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 5

[Meg Viar [:mviar]]

We're discussing a potential workaround - I'll upgrade the severity if we decide it isn't sufficient.

Comment 6

[Meg Viar [:mviar]]

The work around wasn't effective in all cases, so I've increased the severity for uplift into 136 beta.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/425233797eeb
Prevent URL bar from showing through preonboarding modal UI r=nalexander,emilio,urlbar-reviewers,adw

Comment 8

[Meg Viar [:mviar]]

Attachment: Bug 1946517 - Prevent URL bar from showing through preonboarding modal UI

Addresses issue where the URL bar appeared through the UI of the preonboarding modal (see screenshot in bug).

• Show the preonboarding after the "MozAfterPaint" event fires for the browser chrome.
• If for some reason the "MozAfterPaint" event never fires of the event listener was added after it fired, show the modal after 1 second as a fallback.

Original Revision: https://phabricator.services.mozilla.com/D237100

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: The preonboarding modal would have a significant visual glitch where the URL bar content shows through the modal content
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See test plan in https://phabricator.services.mozilla.com/D237100
• Risk associated with taking this patch: Low
• Explanation of risk level: Changes are limited to breakout behavior of the URL bar and have undergone review by multiple reviewers
• String changes made/needed: None
• Is Android affected?: no

Comment 10

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Users will see a significant visual glitch where the URL bar bleeds through the preonboarding modal displayed in our 136 experiment
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See test steps in https://phabricator.services.mozilla.com/D237100
• Risk associated with taking this patch: Low
• Explanation of risk level: This patch only affects URL breakout behavior and has been reviewed by several reviewers
• String changes made/needed: none
• Is Android affected?: no

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/425233797eeb

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/11a273c9b42f