194662 - [mach] mach-o static builds busted

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[hacker formerly known as [e-mail]]

The build fails complaining about object files having 'local relocation entries
in non-writable section (__TEXT,__text)'.  This is caused by linking in object
files which were not compiled with -fPIC.

Comment 1

[hacker formerly known as [e-mail]]

Attachment: Sprinkle FORCE_USE_PIC liberally

Comment 2

[Conrad Carlen (not reading bugmail)]

Comment on attachment 115350 [details] [diff] [review]
Sprinkle FORCE_USE_PIC liberally

r=ccarlen

Is there a perf hit for using fPIC on PowerPC? I kinda doubt it. If there's any
OSX-specific doc on this issue that you read, I'd be curious.

Comment 3

[hacker formerly known as [e-mail]]

Attachment: Fix intree zlib static builds

Silly ordering issue though as the warning states, we may want to think about
using -bind_at_load as lazy loading could cause the wrong set of symbols to be
loaded.

Comment 4

[hacker formerly known as [e-mail]]

Attachment: fix viewer too

Comment 5

[Stuart Parmenter]

Comment on attachment 115619 [details] [diff] [review]
fix viewer too

conrad: yeah, there will be some perf hit.. but its probably not too noticable.

Comment 6

[hacker formerly known as [e-mail]]

Patch has been checked in.

Comment 7

[Tracy Walker [:tracy]]

verified

Comment 8

[J.J. Enser]

I made several attempts to run a static build on the nightly build machine, by
adding the following options to mozconfig:
ac_add_options --enable-static
ac_add_options --disable-shared

... but never succeeded.
Log file will follow.

Comment 9

[J.J. Enser]

Attachment: Static build failure log, part 1

Comment 10

[J.J. Enser]

Attachment: Static build failure log, part 2