Closed Bug 1946752 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 50562 - [functions] Support @supports within @function rules

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
137 Branch
Tracking Flags:
Tracking Status
firefox137 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50562 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50562
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[functions] Support @supports within @function rules

This CL adds support for conditional rules within @function,
starting with @supports, since it's the easiest to deal with.

Support for @media and @container will come later.

Bug: 325504770
Change-Id: Ica51aa6ba806e986cb273374da16a2fa5f3c2a05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6227574
Commit-Queue: Anders Hartvoll Ruud \<andruud@chromium.org>
Reviewed-by: Steinar H Gunderson \<sesse@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1417286}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 6 subtests

Status Summary

Firefox

OK : 2
FAIL: 40

Chrome

OK : 2
FAIL: 40

Safari

OK : 2
FAIL: 40

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-mixins/at-function-cssom.tentative.html [wpt.fyi]
    • Empty CSSFunctionRule: FAIL (Chrome: FAIL, Safari: FAIL)
    • Single CSSFunctionDeclarations: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionDescriptors (result): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionDescriptors (result, repeated): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionDescriptors (local variables): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionDescriptors (local variables, repeated): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionDescriptors (local variables and result): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionDescriptors serialization: FAIL (Chrome: FAIL, Safari: FAIL)
    • Unknown descriptors: FAIL (Chrome: FAIL, Safari: FAIL)
    • Unknown descriptors (mutation): FAIL (Chrome: FAIL, Safari: FAIL)
    • item(): FAIL (Chrome: FAIL, Safari: FAIL)
    • Indexed property getter: FAIL (Chrome: FAIL, Safari: FAIL)
    • @supports in body: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.name: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.getParameters(): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.returnType: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule escapes: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.cssText (--empty): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.cssText (--ret-length): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.cssText (--ret-length-auto): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.cssText (--param-single): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.cssText (--param-typed): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.cssText (--param-typed-default): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.cssText (--param-default): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.cssText (--param-multi): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.cssText (--param-multi-mixed): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.cssText (--body-result): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.cssText (--body-locals): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.cssText (--param-type-fn): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.cssText (--param-type-fn-uni): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.cssText (--ret-type-fn): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.cssText (--ret-type-fn-uni): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.cssText (--body-result-multi): FAIL (Chrome: FAIL, Safari: FAIL)
    • CSSFunctionRule.cssText (--escaped-): FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-mixins/function-conditionals.html [wpt.fyi]
    • Basic @supports: FAIL (Chrome: FAIL, Safari: FAIL)
    • Basic @supports (false): FAIL (Chrome: FAIL, Safari: FAIL)
    • Nested @supports: FAIL (Chrome: FAIL, Safari: FAIL)
    • Nested @supports (false): FAIL (Chrome: FAIL, Safari: FAIL)
    • Inconsequential conditional: FAIL (Chrome: FAIL, Safari: FAIL)
    • @supports with locals: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9f74f4ee97e3 [wpt PR 50562] - [functions] Support @supports within @function rules, a=testonly https://hg.mozilla.org/integration/autoland/rev/8336d3ff7ef2 [wpt PR 50562] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ef595fe18cf2 [wpt PR 50562] - [functions] Support @supports within @function rules, a=testonly https://hg.mozilla.org/integration/autoland/rev/c3f133789e64 [wpt PR 50562] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ef595fe18cf2
https://hg.mozilla.org/mozilla-central/rev/c3f133789e64

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox137: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
You need to log in before you can comment on or make changes to this bug.