Closed Bug 1946760 Opened 1 month ago Closed 1 month ago

4.87 - 2.43% speedometer3 React-Stockcharts-SVG/PanTheChart/Sync / speedometer3 React-Stockcharts-SVG/PanTheChart/total (Android) regression on Mon January 27 2025

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
137 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox135 --- unaffected
firefox136 --- unaffected
firefox137 --- fixed

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Regression)

Details

(Keywords: perf, perf-alert, regression)

Perfherder has detected a browsertime performance regression from push ef3cc8214ba8b349e4b64f42b1ffb4cc69d851fb. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Test Platform Options Absolute values (old vs new) Performance Profiles
5% speedometer3 React-Stockcharts-SVG/PanTheChart/Sync android-hw-a55-14-0-aarch64-shippable fission webrender 18.21 -> 19.09
2% speedometer3 React-Stockcharts-SVG/PanTheChart/total android-hw-a55-14-0-aarch64-shippable fission webrender 46.15 -> 47.28

Improvements:

Ratio Test Platform Options Absolute values (old vs new) Performance Profiles
3% speedometer3 React-Stockcharts-SVG/Render/Async macosx1400-64-shippable-qr fission webrender 2.87 -> 2.79 Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 43599

The following documentation link provides more information about this command.

For more information on performance sheriffing please see our FAQ.

If you have any questions, please do not hesitate to reach out to afinder@mozilla.com.

Flags: needinfo?(wmedina)

Fixed by backout already.

This is the second already fixed by backout bug opened, filed eleven days after the original landing. Can the bot be a bit smarter here?

Flags: needinfo?(wmedina) → needinfo?(afinder)
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED

A comment containing a reason for why the performance regression was resolved as FIXED could not be found. It should provided when the status of the bug is changed.

:mgaudet, since you resolved this bug, could you provide a comment explaining the resolution? If one has already been provided, this needinfo can be ignored/removed.

If you need additional information/help, reach out in #perftest, or #perfsheriffs on Element.

For more information, please visit BugBot documentation.

Flags: needinfo?(mgaudet)

Already mentioned.

Feature request to the bugbot maintainers: Also check some comments from near the resolution for however you're automatically checking.

Flags: needinfo?(mgaudet) → needinfo?(smujahid)

The bot checks for comments mad with the resolution field change or right after it. But if you already provided the explaination, it ok to jsut clear the needinfo.

Feature request to the bugbot maintainers: Also check some comments from near the resolution for however you're automatically checking.

Thank you for the suggestion. I filed an issue to follow up on this: https://github.com/mozilla/bugbot/issues/2584

Flags: needinfo?(smujahid)

Thanks Matthew, I've set the linked alert to backedout.

Flags: needinfo?(afinder)
You need to log in before you can comment on or make changes to this bug.