1946761 - It is possible to save a tab group in private browsing mode and restore it in non-private mode

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect, P1)

Description

[Jeremy Swinarton]

STR:

1. Open two windows, one private and one non-private.
2. In the private window, open a few non-about:blank tabs and add them to a tab group.
3. Right click the tab group label and click "Save and close group."
4. In the non-private window, open the tab overflow menu.
5. Click the tab group that appears.

Actual result:

• The tab group is restored.

Expected result:
All steps from 3 onward should be impossible. The "save and close group" dialog should be disabled in private windows.

Notes:
This should probably be disabled also at the API level. I feel it's necessary to be extra sure it's impossible for tabs to cross the private/non-private boundary.

Comment 1

[Jeremy Swinarton]

Attachment: Bug 1946761: Prevent saving tab groups in private windows r?dao,dwalker

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd47348d718c
Prevent saving tab groups in private windows r=dao,sessionstore-reviewers,tabbrowser-reviewers

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/dd47348d718c