Closed Bug 1946835 Opened 1 month ago Closed 26 days ago

"Turn off Vertical Tabs" does not revert all changes made by "Turn on Vertical Tabs"

Categories

(Firefox :: Sidebar, defect, P2)

Product:
Firefox
Component:
Sidebar
Type:
defect

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: fpwoshg, Assigned: jsudiaman)

References

Details

(Whiteboard: [fidefe-sidebar])

Steps to reproduce

  1. Load Firefox with a new profile.
  2. Right-click a tab and choose "Turn on Vertical Tabs".
  3. Right-click a tab and choose "Turn off Vertical Tabs".

Expected results

Firefox should look the same before and after toggling vertical tabs.

Actual results

After the vertical tabs are toggled on and off, the mini-sidebar is now permanently shown and a sidebar button is added to the main toolbar.

Notes

Given how easy this is to accidentally trigger, turning it off should be made completely frictionless.

Type: enhancement → defect
Priority: -- → P1
Whiteboard: [fidefe-sidebar]
Assignee: nobody → jsudiaman
Status: NEW → ASSIGNED

Here are some variations of this interaction that we could possibly perform. On the latest version of Nightly, here are the results I'm seeing.

Preconditions:
Revamp disabled.

Steps:

  1. Context click a tab -> "Turn on Vertical Tabs".
  2. Context click the same tab -> "Turn off Vertical Tabs."

Expected Result:
Tabs are horizontal. Launcher is hidden (but the toolbar button remains).

Actual Result:
Tabs are horizontal. Launcher is visible and collapsed.

Preconditions:
Revamp enabled. Tabs are horizontal. Launcher is hidden.

Steps:

  1. Navigate to about:preferences.
  2. Under "Browser Layout", switch to Vertical tabs.
  3. Switch back to Horizontal tabs.

Expected Result:
Tabs are horizontal. Launcher is hidden (but the toolbar button remains).

Actual Result:
Tabs are horizontal. Launcher is visible and collapsed.

It would be good to double check that this is indeed the existing behavior, and that the expected behaviors previously mentioned are correct for these cases.

PikeUK, can you take a look at Jonathan's different scenarios (it sounds like the first is what you had mentioned) and see if those capture the exact steps to reproduce and whether you are in fact still seeing the launcher visible.

Flags: needinfo?(me)
Priority: P1 → P2
Severity: -- → S3

Both of those steps to reproduce leave the launcher visible and the extra button on the toolbar for me, on both Beta and Nightly on Windows 11 Pro 24H2.

Flags: needinfo?(me)

This option has been removed, see Bug 1946868.

Status: ASSIGNED → RESOLVED
Closed: 26 days ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.