1947164 - Incremental builds don't update MOZ_BUILDID

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Andreas Pehrson [:pehrsons]]

It was pointed out in D237105 that the buildid gets updated on every build, clobber and incremental alike.

I was not seeing this on incremental builds. Had it been, bug 1945648 would have had much bigger impact. OTOH it would probably have been filed sooner!

Reversing bug 1873959 locally brings buildid.h generation back on incremental builds.

See nop build (ref bug 1873959) outputs, for local builds, below.

• Latest m-c (profile):

  apehrson@Mac m-c-2 % ./mach build
  0:00.34 W Clobber not needed.
  0:00.66 W Adding make options from /Users/apehrson/Dev/m-c-2/.mozconfig
  export RUSTC_WRAPPER=buildcache
  AUTOCLOBBER=1
  MOZ_OBJDIR=/Users/apehrson/Dev/m-c-2/obj-aarch64-apple-darwin24.3.0
  OBJDIR=/Users/apehrson/Dev/m-c-2/obj-aarch64-apple-darwin24.3.0
  FOUND_MOZCONFIG=/Users/apehrson/Dev/m-c-2/.mozconfig
  export FOUND_MOZCONFIG
  Parallelism determined by memory: using 12 jobs for 12 cores based on 32.0 GiB RAM and estimated job size of 1.0 GiB
  0:00.66 /usr/bin/make -f client.mk -j12 -s
  0:07.12 Packaging [e-mail]...
  0:09.92 Packaging [e-mail]...
  0:10.10 W 1004 compiler warnings present.
  0:10.20 W Overall system resources - Wall time: 10s; CPU: 59%; Read bytes: 1248034816; Write bytes: 418181120; Read time: 8614; Write time: 109
  0:10.20 W Swap in/out (MB): 604.140625/0.0
  To view a profile of the build, run |mach resource-usage|.
  0:10.20 Your build was successful!
  To take your build for a test drive, run: |mach run|
  For more information on what to do now, see https://firefox-source-docs.mozilla.org/setup/contributing_code.html

• Latest m-c with bug 1873959 backed out (profile):

  apehrson@Mac m-c-2 % ./mach build
  0:00.37 W Clobber not needed.
  0:00.50 W Adding make options from /Users/apehrson/Dev/m-c-2/.mozconfig
  export RUSTC_WRAPPER=buildcache
  AUTOCLOBBER=1
  MOZ_OBJDIR=/Users/apehrson/Dev/m-c-2/obj-aarch64-apple-darwin24.3.0
  OBJDIR=/Users/apehrson/Dev/m-c-2/obj-aarch64-apple-darwin24.3.0
  FOUND_MOZCONFIG=/Users/apehrson/Dev/m-c-2/.mozconfig
  export FOUND_MOZCONFIG
  Parallelism determined by memory: using 12 jobs for 12 cores based on 32.0 GiB RAM and estimated job size of 1.0 GiB
  0:00.50 /usr/bin/make -f client.mk -j12 -s
  0:00.92 ./buildid.h.stub
  0:00.92 ./source-repo.h.stub
  0:01.40 ./application.ini.stub
  0:01.50 ./application.ini.h.stub
  0:01.97 browser/app
  0:04.12 browser/app/firefox
  0:04.36 ./source-repo.h.stub
  0:04.36 ./buildid.h.stub
  0:06.26 ./application.ini.stub
  0:07.43 Packaging [e-mail]...
  0:10.25 Packaging [e-mail]...
  0:10.45 W 1004 compiler warnings present.
  0:10.55 W Overall system resources - Wall time: 10s; CPU: 59%; Read bytes: 548573184; Write bytes: 421498880; Read time: 5319; Write time: 111
  0:10.55 W Swap in/out (MB): 86.640625/0.0
  To view a profile of the build, run |mach resource-usage|.
  0:10.55 Your build was successful!
  To take your build for a test drive, run: |mach run|
  For more information on what to do now, see https://firefox-source-docs.mozilla.org/setup/contributing_code.html

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1873959

:sergesanspaille, since you are the author of the regressor, bug 1873959, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[[:sergesanspaille]]

Attachment: Bug 1947164 - Fix pruning of build-id rebuild r=glandium!

Adjust to internal changes so that buildid.h and source-repo.h are
generated only once (and not twice - or never) upon nop build.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afe2ba0f432e
Fix pruning of build-id rebuild r=glandium

Comment 4

[amarc]

Backed out for causing py3 failures @ test_faster_make

• Backout link
• Push with failures
• Failure Log
• Failure line:

python/mozbuild/mozbuild/test/backend/test_build.py::TestBuild::test_faster_make TEST-UNEXPECTED-FAIL

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d6cef080b5c
Fix pruning of build-id rebuild r=glandium

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9d6cef080b5c