Closed Bug 1947187 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 50606 - Ensure that attr-taint carries through if()

Tracking

()

Status:

RESOLVED FIXED

Milestone:

137 Branch

Tracking Flags:

Tracking

Status

firefox137

---

fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

1 month ago

Sync web-platform-tests PR 50606 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50606
Details from upstream follow.

Munira Tursunova <moonira@google.com> wrote:

Ensure that attr-taint carries through if()

This is not speced yet, but the logic is following:

if there is attr-tainted value in the if() condition, either in custom
property or query specified value, that doesn't affect the return value,
so returned value would not be tainted just because if that.

if the picked declaration value is attr()-tainted, the return value of
if() function becomes tainted.

unused declaration value does not affect the attr()-tainting of the
returned value.

This CL also ensures that attr()-tainting does not affect comparison in
the if() style condition.

Bug: 393698480
Change-Id: Ia3c517bb4c89de1a81ff17c40b3b7f0c850fc3fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6239675
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Commit-Queue: Munira Tursunova \<moonira@google.com>
Cr-Commit-Position: refs/heads/main@{#1418112}

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

1 month ago

Component: web-platform-tests → CSS Parsing and Computation

Product: Testing → Core

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

1 month ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf7624518d1ebba168d4d62e2097c01b5fefb8b2

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

1 month ago

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 114 subtests

Status Summary

Firefox

OK : 2
PASS: 14
FAIL: 130[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 132[GitHub]

Chrome

OK : 2
PASS: 26
FAIL: 120

Safari

OK : 2
PASS: 14
FAIL: 132

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-values/attr-security.html [wpt.fyi]
- CSS Values and Units Test: attr() security limitations: FAIL (Chrome: PASS, Safari: FAIL)
- CSS Values and Units Test: attr() security limitations 3: FAIL (Chrome: PASS, Safari: FAIL)
- CSS Values and Units Test: attr() security limitations 5: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: attr() security limitations 6: FAIL (Chrome: PASS, Safari: FAIL)
- CSS Values and Units Test: attr() security limitations 8: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: attr() security limitations 9: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: attr() security limitations 12: FAIL (Chrome: PASS, Safari: FAIL)
- CSS Values and Units Test: attr() security limitations 14: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: attr() security limitations 15: FAIL (Chrome: PASS, Safari: FAIL)
- CSS Values and Units Test: attr() security limitations 16: FAIL (Chrome: PASS, Safari: FAIL)
- CSS Values and Units Test: attr() security limitations 18: FAIL (Chrome: PASS, Safari: FAIL)
- CSS Values and Units Test: attr() security limitations 19: FAIL (Chrome: PASS, Safari: FAIL)
- CSS Values and Units Test: attr() security limitations 20: FAIL (Chrome: PASS, Safari: FAIL)
- CSS Values and Units Test: attr() security limitations 21: FAIL (Chrome: PASS, Safari: FAIL)
- CSS Values and Units Test: attr() security limitations 23: FAIL (Chrome: PASS, Safari: FAIL)
- CSS Values and Units Test: attr() security limitations 24: FAIL (Chrome: PASS, Safari: FAIL)
- CSS Values and Units Test: attr() security limitations 29: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: attr() security limitations 31: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-values/if-style-query.html [wpt.fyi]
- CSS Values and Units Test: CSS inline if() function: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 1: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 2: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 3: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 4: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 5: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 6: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 7: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 8: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 9: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 10: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 11: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 12: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 13: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 14: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 15: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 16: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 17: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 18: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 19: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 20: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 21: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 22: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 23: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 24: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 25: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 26: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 27: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 28: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 29: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 30: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 31: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 32: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 33: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 34: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 35: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 36: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 37: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 38: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 39: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 40: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 41: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 42: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 43: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 44: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 45: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 46: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 47: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 48: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 49: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 50: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 51: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 52: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 53: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 54: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 55: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 56: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 57: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 58: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 59: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 60: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 61: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 62: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 63: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 64: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 65: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 66: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 67: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 68: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 69: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 70: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 71: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 72: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 73: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 74: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 75: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 76: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 77: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 78: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 79: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 80: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 81: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 82: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 83: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 84: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 85: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 86: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 87: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 88: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 89: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 90: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 91: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 92: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 93: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 94: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 95: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 96: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 97: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 98: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 99: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 100: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 101: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 102: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 103: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 104: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 105: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 106: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 107: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 108: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 109: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 110: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 111: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 112: FAIL (Chrome: FAIL, Safari: FAIL)
- CSS Values and Units Test: CSS inline if() function 113: FAIL (Chrome: FAIL, Safari: FAIL)

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

1 month ago

Blocks: 1947226

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

1 month ago

Depends on: 1947323

Pulsebot

Comment 3

•

1 month ago

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/36fbe00fe522 [wpt PR 50606] - Ensure that attr-taint carries through if(), a=testonly https://hg.mozilla.org/integration/autoland/rev/577714845f28 [wpt PR 50606] - Update wpt metadata, a=testonly

Sandor Molnar[:smolnar]

Comment 4

•

1 month ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/36fbe00fe522
https://hg.mozilla.org/mozilla-central/rev/577714845f28

Status: NEW → RESOLVED

Closed: 1 month ago

status-firefox137: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 137 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

[wpt-sync] Sync PR 50606 - Ensure that attr-taint carries through if()

Categories

(Core :: CSS Parsing and Computation, task, P4)

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Updated

Comment 1

Comment 2

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

Updated

Updated

Comment 3

Comment 4