1947195 - Newtab showWeather has Nimbus setup prefs mismatch

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Scott [:thecount] Downe]

showWeather is using Services.prefs.getStringPref to get the setup prefs, but the Nimbus feature manifest is using fallbackPref.

This was regressed in bug 1924597. Before that bug, it was using fallbackPref and NimbusFeatures.pocketNewtab.getVariable.

It should have been moved to setPref and Services.prefs.getStringPref, but the feature manifest never got the change for using setPref, and is still using fallbackPref.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1947195 - Newtab weather widget rollout mechanism mismatch

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1924597

Comment 3

[Maxx Crawford [:maxx]]

To test this patch, you'll want to enroll in a study.

Prefs

Set the following prefs to true:

• nimbus.debug

Testing steps:

1. Verify the following weather locale/region config prefs BEFORE enrolling in the study.
2. Open about:config.
3. Expected:
   • browser.newtabpage.activity-stream.discoverystream.locale-weather-config : en-US,en-GB,en-CA
   • browser.newtabpage.activity-stream.discoverystream.region-weather-config: US,CA
4. Enroll in the following study:
   about:studies?optin_slug=hnt-weather-with-location-selector-non-eu-expansion&optin_branch=control&optin_collection=nimbus-preview
5. Expected: The about:studies page should open, with a notification at the top of the page of "Opt-in was successful."
6. Open about:config
7. Expected:
   • browser.newtabpage.activity-stream.discoverystream.locale-weather-config : hi-IN, kn, mr, pa-IN, ta, te, tr, ur, en-US, en-CA, en-GB
   • browser.newtabpage.activity-stream.discoverystream.region-weather-config: IN, BD, PK, TR

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50264c4bfe32
Newtab weather widget rollout mechanism mismatch r=maxx

Comment 5

[Reem Hamoui]

Attachment: Bug 1947195 - Newtab weather widget rollout mechanism mismatch

Original Revision: https://phabricator.services.mozilla.com/D237593

Comment 6

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Wrong prefs will be set, feature won't show as intended
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Tests in bugzilla
• Risk associated with taking this patch: low
• Explanation of risk level: Small pref changes
• String changes made/needed: None
• Is Android affected?: no

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/50264c4bfe32

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/d406818c6af4

Comment 9

[Reem Hamoui]

Attachment: Bug 1947195 - Newtab weather widget rollout mechanism mismatch

Original Revision: https://phabricator.services.mozilla.com/D237593

Comment 10

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: Wrong prefs will be set, feature won't show as intended
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Steps found in bugzilla
• Risk associated with taking this patch: low
• Explanation of risk level: Small pref changes
• String changes made/needed: None
• Is Android affected?: no

Comment 11

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 137.0a1 (Build ID: 20250211214755) and latest Beta 136.0b5 try build (Build ID: 20250211132255) downloaded from treeherder on Windows 10 x64, macOS 17.4.1 and Linux Mint 20.1.

• The Weather Widget is successfully enabled and displayed using Nimbus.

I will leave the "qe-verify+" flag set in case the fix is also uplifted in Firefox Release 135.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/6b4811b8e220

Comment 13

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Firefox Release 135.0.1 (Build ID: 20250216192613) on Windows 11 x64, macOS 17.4.1 and Linux Mint 20.1.

• The Weather Widget is successfully enabled and displayed using Nimbus.