1947225 - Shortcut title overflowing in Edit/New Shortcut dialogs from about:home

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: screenshot

Found in

• 136.0b3

Affected versions

• 137.0a1
• 136.0b3
• 135.0

Tested platforms

• Affected platforms: Windows 11, macOS 14, Ubuntu 22.04
• Unaffected platforms: none

Steps to reproduce

1. Navigate to about:home and add a new shortcut or edit an existing one by opening the 3-dot menu from any shortcut
2. In the New/Edit Shortcut dialog, enter a long title in the “Title” field (e.g. TestTestTestTestTestTestTestTestTestTestTest)
3. Observe how the title is displayed under the shortcut image

Expected result

• The title is truncated and there are no overflow issues

Actual result

• The title is not truncated. If the entered text contains no spaces, it extends across horizontally. If the text contains spaces, it wraps onto multiple lines, causing the dialog height to increase

Regression range

• Last good build: 2024-12-05
• First bad build: 2024-12-06
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=25396aa6b22994d5ce0ba4b961bbf64797d57193&tochange=0030e1c01a2f651cb086e573814f67729598eec9
• Potentially regressed by: 1433530

Additional notes

• See the attached screenshot

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:rhamoui, since you are the author of the regressor, bug 1433530, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Reem Hamoui]

Attachment: Bug 1947225 - Fix tile text overflow in topsites form. r=#home-newtab-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01c311a854a9
Fix tile text overflow in topsites form. r=home-newtab-reviewers,nbarrett

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/01c311a854a9

Comment 5

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Verified as fixed on Firefox Nightly 137.0a1 (2025-02-13), using macOS 14.7, Windows 11 and Ubuntu 22.04. Shortcut title is no longer overflowing in Edit/New Shortcut dialogs from about:home.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:rhamoui, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox136 to wontfix.

For more information, please visit BugBot documentation.