1947233 - [wpt-sync] Sync PR 50611 - Revert "Fixed purely physical mapping bug for vertical text and decorations."

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50611 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50611
Details from upstream follow.

Fredrik Söderquist <[e-mail]> wrote:

Revert "Fixed purely physical mapping bug for vertical text and decorations."

This reverts commit 5cf5660d7abb5c2de0b43156c382eadba9c2abe6.

Reason for revert: Caused performance issues

Original change's description:

Fixed purely physical mapping bug for vertical text and decorations.

This fix was achieved by replacing DrawLooper with a filter and implementing the translation of the shadow offset using the value of writing mode.

Additionally, this CL is a portion of the fix discussed in a previous CL regarding text-shadow (please refer to the discussion at https://chromium-review.googlesource.com/c/chromium/src/+/5380302).

Therefore, a fix for the painting order of text and decoration shadows will follow.

Bug: 40829719
Change-Id: I9186e1673d14ba419a791efb09060c6f876d5b8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484626
Reviewed-by: Fredrik Söderquist \<[e-mail]>
Reviewed-by: Stephen Chenney \<[e-mail]>
Commit-Queue: Stephen Chenney \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1398959}

Bug: 40829719
Bug: 394893130
Bug: 391914237
Change-Id: I2c3528d58f6ac8d98b6289c313db574271127fbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6249857
Commit-Queue: Fredrik Söderquist \<[e-mail]>
Reviewed-by: Daniel Yip \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1418182}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=90690149d33bd46145b14c07f60902b5d137e0fb

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 13 tests

Status Summary

Firefox

PASS: 9
FAIL: 4

Chrome

PASS: 7
FAIL: 6

Safari

PASS: 7
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-pseudo/highlight-painting-002.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-pseudo/highlight-painting-shadows-horizontal.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-pseudo/highlight-painting-shadows-vertical.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-pseudo/target-text-shadow-vertical.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ee086ad87ea
[wpt PR 50611] - Revert "Fixed purely physical mapping bug for vertical text and decorations.", a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8ee086ad87ea