1947348 - `mach run --debug --no-install --no-attach` has trouble with unrooted phones

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Ted Campbell [:tcampbell]]

./mach run --app=org.mozilla.fenix.debug --debug --no-install --no-attach doesn't work for my on physical Pixel 3 / 7 phones due to /sdcard permissions.

The root of this is here: https://searchfox.org/mozilla-central/rev/3166120f85161b7fe84565135b04c685da1dd34f/testing/mozbase/mozdevice/mozdevice/adb.py#2562

In other scenarios we have been supporting modern unrooted phones by using the /data/local/tmp directory as a scratch space that is owned by adb shell user and can easily be shared to applications.

In a related manner, the enable_run_as mechanism doesn't work here because we don't set the app in the lldb install code path.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1947348 - Better support `mach run --debug` on unrooted Android devices

Use the /data/local/tmp folder as a bounce directory instead of /sdcard since
that isn't generally accessible after Android 10 (2020). Also ensure that the
app name is recorded as the run-as app in more code paths.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7f447bf68c6
Better support `mach run --debug` on unrooted Android devices r=owlish

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c7f447bf68c6