1947356 - Minor clean up in nsGridContainerFrame::Reflow()

Status: RESOLVED FIXED

(Core :: Layout: Grid, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

See the patches for details.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1947356 Part 1 - Remove two local variables that are used only once in nsGridContainerFrame::Reflow().

Specifically, computedSize and containSize are both used only once. I don't
feel we should bother creating them.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1947356 Part 2 - Rewrite trackSizingBSize initialization to improve readability.

Also, improve the comment since other non-auto values of block-size could also
resolve to unconstrained block size.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/786c6d3e4be4
Part 1 - Remove two local variables that are used only once in nsGridContainerFrame::Reflow(). r=tlouw
https://hg.mozilla.org/integration/autoland/rev/c8807bf30858
Part 2 - Rewrite trackSizingBSize initialization to improve readability. r=layout-grid-reviewers,tlouw

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/786c6d3e4be4
https://hg.mozilla.org/mozilla-central/rev/c8807bf30858