1947403 - TypeError: can't access property "intent", suggestion is null

Status: RESOLVED FIXED

(Core :: Machine Learning, defect)

Description

[Tarek Ziadé (:tarek)]

Running the suggest perf test I get an error

$ MOZ_FETCHES_DIR=/Users/tarekziade/Dev/fetches ./mach perftest toolkit/components/ml/tests/browser/browser_ml_suggest_inference.js --hooks toolkit/components/ml/tests/tools/hooks_local_hub.py --mochitest-extra-args headless

  FAIL Uncaught exception in test bound test_ml_generic_pipeline - at chrome://mochitests/content/browser/toolkit/components/ml/tests/browser/browser_ml_suggest_inference.js:131 - TypeError: can't access property "intent", suggestion is null

I also noticed in the code that all errors are silently captured by MLSuggest making it a bit hard to spot the issue

We should avoid this design and capture at least in the logs unintended behaviors - e.g. a suggest feature not ready is different from a feature that runs and fails.

Comment 1

[cgopal]

Attachment: Bug 1947403 - ml_suggest_inference changed to serial asyncs r?tarek

Comment 2

[cgopal]

Thanks @tarek!
The problem was around the batching of test inference data. I tested the fix locally now
MOZ_FETCHES_DIR=/Users/cgopal/work/perf-models ./mach perftest toolkit/components/ml/tests/browser/browser_ml_suggest_inference.js --hooks toolkit/components/ml/tests/tools/hooks_local_hub.py --mochitest-extra-args headless
Please find the changes in https://phabricator.services.mozilla.com/D237799

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2969bc17af29
ml_suggest_inference changed to serial asyncs r=tarek

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/2969bc17af29