1947420 - [wpt-sync] Sync PR 50623 - `DataTransferItem`: improve spec compliance

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50623 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50623
Details from upstream follow.

Gae24 <[e-mail]> wrote:

DataTransferItem: improve spec compliance

<!-- Please describe your changes on the following line: -->
Avoid copying the kind enum inside DataTransferItem when constructing it; fetch it through drag_data_store instead.
According to spec if an item is removed from the drag data store item list, the corresponding DataTransferItem will be in a disabled mode.

I decided to use IndexMap since it was already a dependency and access by both index and a key was required.
For key i simply used a u16, maybe use a newtype for clarity?

Reviewed in servo/servo#35418

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b960f04f67af0b7b4206a661aa127bd16dcc98f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 1

Chrome

OK : 1
PASS: 1
FAIL: 1

Safari

OK : 1
PASS: 1
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/editing/dnd/datastore/datatransferitemlist-remove.html [wpt.fyi]
  • remove()ing an item will put the associated DataTransferItem object in the disabled mode: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9abf2559ad08
[wpt PR 50623] -  `DataTransferItem`: improve spec compliance, a=testonly
https://hg.mozilla.org/integration/autoland/rev/884f282bc588
[wpt PR 50623] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9abf2559ad08
https://hg.mozilla.org/mozilla-central/rev/884f282bc588