Closed
Bug 1947482
Opened 1 year ago
Closed 1 year ago
Refactor anchor() resolution function to take in resolution axis, not side
Categories
(Core :: Layout: Positioned, enhancement)
Core
Layout: Positioned
Tracking
()
RESOLVED
FIXED
137 Branch
| Tracking | Status | |
|---|---|---|
| firefox137 | --- | fixed |
People
(Reporter: dshin, Assigned: dshin)
References
Details
(Whiteboard: [anchorpositioning:m1])
Attachments
(1 file)
We really don't care about the exact side, and this makes some logic easier because we don't have to keep track of the exact side.
|
||
Updated•1 year ago
|
Whiteboard: [anchorpositioning:m1]
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Updated•1 year ago
|
Assignee: nobody → dshin
Status: NEW → ASSIGNED
Pushed by dshin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d1903e35fc5
Anchor resolution takes axis, not side. r=firefox-style-system-reviewers,emilio
Backed out for causing build bustages @ ServoStyleConstsInlines
- Backout link
- Push with failures
- Failure Log
- Failure line:
/builds/worker/workspace/obj-build/dist/include/mozilla/ServoStyleConstsInlines.h(1292,47): error: reference to 'Side' is ambiguous
Flags: needinfo?(dshin)
Pushed by dshin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a054f060766
Anchor resolution takes axis, not side. r=firefox-style-system-reviewers,emilio
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox137:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
|
|
Assignee | |
Updated•9 months ago
|
Flags: needinfo?(dshin)
You need to log in
before you can comment on or make changes to this bug.
Description
•