1947491 - [wpt-sync] Sync PR 50635 - Expose Captured Surface Resolution while screensharing for Windows

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50635 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50635
Details from upstream follow.

Palak Agarwal <[e-mail]> wrote:

Expose Captured Surface Resolution while screensharing for Windows

This change allows the MediaStreamTrack to expose physical and logical
dimensions of the captured track while screensharing. We get width and
height per frame using its metadata.source_size as that is unaffected by
applyConstraints.

For non-chrome window and screen captures, we need the device scale
factor from windows platform API. This work is in a separate WebRTC CL.

A follow-up change would be to add an 'capturedsurfacedimensionschanged'
event or reuse the existing 'configurationchange' event which would be
triggered whenever the dimensions change.

These new properties exposed by MediaTrackSettings are guarded by the
RuntimeEnabled flag 'CapturedSurfaceResolution'.

Design doc: go/expose-captured-surface-resolution

Bug: 383946052
Change-Id: Iedb06a85af13a8abc4dcedc04d971d32c29aa16c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6089100
Reviewed-by: Mark Foltz \<[e-mail]>
Reviewed-by: Guido Urdaneta \<[e-mail]>
Reviewed-by: Philip Jägenstedt \<[e-mail]>
Commit-Queue: Palak Agarwal \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1418642}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f0ca39dcaa2e248740fbd9df4e141ca6ee96259

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

PASS : 2
FAIL : 4
ERROR: 1

Chrome

PASS : 6
ERROR: 1

Safari

OK : 1
FAIL : 6

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /screen-capture/tentative/getdisplaymedia-captured-surface-resolution.https.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: OK)
  • getDisplayMedia() and resolution for captured surface type monitor: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia() and resolution for captured surface type window: FAIL (Chrome: PASS, Safari: FAIL)
  • applyConstraints() should not change the physical and logical size of captured surface type monitor: FAIL (Chrome: PASS, Safari: FAIL)
  • applyConstraints() should not change the physical and logical size of captured surface type window: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd7d0332537a
[wpt PR 50635] - Expose Captured Surface Resolution while screensharing for Windows, a=testonly
https://hg.mozilla.org/integration/autoland/rev/2aa41bb8ef14
[wpt PR 50635] - Update wpt metadata, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/bd7d0332537a
https://hg.mozilla.org/mozilla-central/rev/2aa41bb8ef14