1947526 - sidebar.visibility pref gets reset after each browser restart

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[Kelly Cochrane [:kcochrane]]

When using vertical tabs, if you set the visibility for the sidebar to expand on hover or always hide, then restart the browser, the sidebar.visibility pref gets reset to "always-show" after every browser restart.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1944931

:sfoster, since you are the author of the regressor, bug 1944931, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Sam Foster [:sfoster] (he/him)]

Thanks, I think I see the issue and shouldn't be hard to fix. This call to handleVerticalTabsPrefChange from SidebarManager's init is going to unconditionally set the visibility pref back to its default at startup, regardless of what the user might have customized it to be.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1947526 - Preserve user's visibility pref value and fix default expanded state when switching to vertical tabs. r?#sidebar-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f7deb04827b
Preserve user's visibility pref value and fix default expanded state when switching to vertical tabs. r=sidebar-reviewers,nsharpley,kcochrane

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8f7deb04827b

Comment 6

[Donal Meehan [:dmeehan]]

:sfoster could you add a beta uplift request on this when ready, since it's a regression from Bug 1944931

Comment 7

[Sarah Clements [:sclements]]

Attachment: Bug 1947526 - Preserve user's visibility pref value and fix default expanded state when switching to vertical tabs.

• Make sure we don't overwrite a user's choice to hide-sidebars in vertical tabs at startup
• Roll in a fix to bug 1947257 and ensure the launcher is initially expanded when enabling vertical tabs

Original Revision: https://phabricator.services.mozilla.com/D237849

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Subpar user experience
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See bug comments
• Risk associated with taking this patch: Medium
• Explanation of risk level: Its contained to sidebar code and has test coverage
• String changes made/needed: No
• Is Android affected?: no

Comment 9

[Sarah Clements [:sclements]]

Hi Donal, I just rebased this on beta and resolved the merge conflicts for Sam (he's in PST). It should be good to go!

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/3bb77cef6217

Comment 11

[amarc]

Backed out from mozilla-beta for causing bc failures @ browser_pinnedTabs.js

• Backout link
• Push with failures
• Failure Log
• Failure line:

TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_pinnedTabs.js | uncaught exception - ResizeObserver loop completed with undelivered notifications. at :0:0

Comment 12

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Reproduced the issue on Firefox 137.0a1 (2025-02-11) by following the infos provided in Comment 0 on macOS 15.3.1.

The issue is fixed on Firefox 137.0a1 (2025-02-16). Tests were performed on macOS 15.3.1, Ubuntu 24.04 and Windows 11.

Comment 13

[Donal Meehan [:dmeehan]]

Setting 136 back to affected since this was backed out after introducing test failures

Comment 14

[Sarah Clements [:sclements]]

Since this didn't make it in to the Monday beta build, I'm cancelling this request as it seems to risky to keep trying at this stage.