Closed Bug 1947588 Opened 1 month ago Closed 11 days ago

Reword JSMSG_TEMPORAL_MISSING_OPTION error message.

Categories

(Core :: JavaScript: Standard Library, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
138 Branch
Tracking Status
firefox138 --- fixed

People

(Reporter: dminor, Assigned: sarahngima77, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

The JSMSG_TEMPORAL_MISSING_OPTION is used to report a missing required option to the developer.

The current wording is "undefined {0} option", I think it would be more helpful to say "required option {0} is undefined".

This is a good first bug, the main complexity will be getting the SpiderMonkey / Firefox build working.

  1. Make sure you can build SpiderMonkey. You can find instructions on building here: https://firefox-source-docs.mozilla.org/js/build.html.
  2. Change the error message, and then make sure the build is still working and you can run the tests. You might need to make some changes to the tests if they were expecting the old error message.
  3. Now you can commit your changes. Your commit message should look like: Bug X - Reword JSMSG_TEMPORAL_MISSING_OPTION error message; r=dminor!, where X is the number for this bug.
  4. Once you have your changes committed, request review. There are instructions on using phabricator and on getting reviews.
Severity: -- → N/A
Priority: -- → P3
Assignee: nobody → sarahngima77
Status: NEW → ASSIGNED
Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9917202ccc95 Reword JSMSG_TEMPORAL_MISSING_OPTION error message; r=dminor
Status: ASSIGNED → RESOLVED
Closed: 11 days ago
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: