Closed Bug 194773 Opened 22 years ago Closed 22 years ago

Add accesskeys to address book card dialog

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: piers, Assigned: piers)

References

()

Details

(Keywords: access)

Attachments

(3 files)

Add accesskeys to address book card dialog.
Only adds keys to Contact and Other tabs because theres not enough accesskeys
to cover all the tabs (scope is over all tabs due to bug 143065 which does look
like its going to be fixed any time soon :( ).
Depends on: 143065
Attachment #115407 - Flags: superreview?(sspitzer)
Attachment #115407 - Flags: review?(dean_tessman)
Comment on attachment 115407 [details] [diff] [review]
Add accesskeys to the Contact and Other tabs

Can you attach a diff -uw, please?
But the other patch is the one for review (files should use spaces not tabs)
Dean: cc'ing you so you notice i've uploaded the whitespace diff.
Comment on attachment 115407 [details] [diff] [review]
Add accesskeys to the Contact and Other tabs

Looks good, r=me.  Seth, I'll leave it up to you whether you want to use this
patch with all the whitespace changes or the other one.
Attachment #115407 - Flags: review?(dean_tessman) → review+
Comment on attachment 115407 [details] [diff] [review]
Add accesskeys to the Contact and Other tabs

Change sr requestee because this has been hanging around for a while.
Attachment #115407 - Flags: superreview?(sspitzer) → superreview?(bienvenu)
Attachment #115407 - Flags: superreview?(bienvenu) → superreview?(dmose)
Comment on attachment 115407 [details] [diff] [review]
Add accesskeys to the Contact and Other tabs

sr=dmose
Attachment #115407 - Flags: superreview?(dmose) → superreview+
Checking in content/abCardOverlay.xul;
/cvsroot/mozilla/mailnews/addrbook/resources/content/abCardOverlay.xul,v  <-- 
abCardOverlay.xul
new revision: 1.42; previous revision: 1.41
done
Checking in locale/en-US/abCardOverlay.dtd;
/cvsroot/mozilla/mailnews/addrbook/resources/locale/en-US/abCardOverlay.dtd,v 
<--  abCardOverlay.dtd
new revision: 1.12; previous revision: 1.11
done
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Sorry, i didn't know there was a spec for this. The only difference is for 
"Additional Email" where I used "A" instead of "o". Do you want this changed? -
personally i think "A" is better anyway. All other keys match.

As i said in comment 1, this only adds keys to the contact and other tabs due to 
bug 143065.
Ok, i see now why the spec doesn't use "A" (because of "Add to"). You want this 
changed?
per spec.
Attachment #118150 - Flags: superreview?(sspitzer)
Reopen bug to match spec.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #118150 - Flags: review?(dean_tessman)
Comment on attachment 118150 [details] [diff] [review]
Correctly match spec

Whoops, I missed that too.  Looks good.
Attachment #118150 - Flags: review?(dean_tessman) → review+
Comment on attachment 118150 [details] [diff] [review]
Correctly match spec

sr=sspitzer
Attachment #118150 - Flags: superreview?(sspitzer) → superreview+
what about the contact tab?
sorry, "Address" tab, not contact tab.
Status: REOPENED → ASSIGNED
Seth: see comment 1.
Checking in mozilla/mailnews/addrbook/resources/content/abNewCardDialog.xul;
/cvsroot/mozilla/mailnews/addrbook/resources/content/abNewCardDialog.xul,v  <--
 abNewCardDialog.xul
new revision: 1.30; previous revision: 1.29
done
Checking in mozilla/mailnews/addrbook/resources/locale/en-US/abCardOverlay.dtd;
/cvsroot/mozilla/mailnews/addrbook/resources/locale/en-US/abCardOverlay.dtd,v 
<--  abCardOverlay.dtd
new revision: 1.13; previous revision: 1.12
done
Checking in mozilla/mailnews/addrbook/resources/locale/en-US/abNewCardDialog.dtd;
/cvsroot/mozilla/mailnews/addrbook/resources/locale/en-US/abNewCardDialog.dtd,v
 <--  abNewCardDialog.dtd
new revision: 1.2; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Closed: 22 years ago22 years ago
Resolution: --- → FIXED
vrfy'd fixed on win2k and linux rh8.0, 2003.04.02 comm bits.
Status: RESOLVED → VERIFIED
Component: Keyboard: Navigation → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: