1947742 - Unable to select a Tab group from the Address bar when a Search engine suggestion is displayed

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: Screencast from 2025-02-12 15-12-47.webm

Found in

• Nightly 137.0a1 (2025-02-11)

Affected versions

• Nightly 137.0a1 (2025-02-11)
• Beta 136.0b4

Affected platforms

• All

Steps to reproduce

1. Create a Tab group with the name Best.
2. Select a different tab and Type B in the url bar.
3. Select the Best Tab group from the Search suggestions

Expected result

• The "Best" Tab Group should be selected and opened.

Actual result

• The Bing search engine is selected.
  The same issue occurs if the DuckDuckGo search engine is displayed

Regression range
Not a regression.

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1947742 - Prevent search actions overriding other actions. r=dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0b7a69be30f
Prevent search actions overriding other actions. r=dao,urlbar-reviewers

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f0b7a69be30f

Comment 4

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly 137.0a1 (2025-02-18) build.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daleharvey, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox136 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Dale Harvey (:daleharvey)]

Attachment: Bug 1947742 - Prevent search actions overriding other actions. r=dao

Original Revision: https://phabricator.services.mozilla.com/D238407

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Broken actions functionality when search action present
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Create tab group with same name as a non default search engine, try to search for tab group name and open via actions
• Risk associated with taking this patch: Low
• Explanation of risk level: Patch is only able to affect related functionality
• String changes made/needed: No
• Is Android affected?: no

Comment 8

[Donal Meehan [:dmeehan]]

:daleharvey tab groups are not enabled in Fx136, so the repro steps are not applicable. I marked Fx136 as disabled earlier.
I don't see why this needs to be uplifted?
Double checking with you before I reject the request, in case there's any concern.

Comment 10

[Donal Meehan [:dmeehan]]

(missed adding an NI in comment 8)

Comment 11

[Dale Harvey (:daleharvey)]

Apologies I should have made non tab groups STR, this is a general bug with actions that are to be released in 136, not only related to tab groups

Non tab groups STR from above duped bug:

Launch Firefox.
Using the Unified Search Button perform a search with Bing search engine.
After the SERP is loaded, click the address bar and clear it of the search term and searchmode.
Type in a Secondary Action keyword e.g. restart
Click the 'Restart' secondary action.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/25553697a8d8

Comment 13

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta build 136.0b8.