1947818 - Sidebar is slow to resize when positioned on the right

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[Kelly Cochrane [:kcochrane]]

There's an issue when resizing the sidebar panel and sidebar launcher when the sidebar is positioned on the right. There's a bit of a visual glitch / lag happening as long as you're dragging the splitters. This does not occur when the sidebar is positioned to the left.

Comment 2

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1947818 - Fix for sidebar splitter issues

Comment 3

[Kelly Cochrane [:kcochrane]]

NOTE: As an interim fix for 137, this only fixes things when expand on hover is NOT enabled. UX/Product are still discussing a potential alternate solution for expand on hover.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/793f8bede918
Fix for sidebar splitter issues r=desktop-theme-reviewers,sidebar-reviewers,jsudiaman,dao

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_sidebar_move.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/sidebar/browser_sidebar_move.js | Correct browser ordinal (start) - [["sidebar-wrapper",""],["tabbrowser-tabbox","6"]] deepEqual [["sidebar-wrapper",1],["tabbrowser-tabbox",2]] -

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75ec289e02ef
Fix for sidebar splitter issues r=desktop-theme-reviewers,sidebar-reviewers,jsudiaman,dao

Comment 7

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_customize_sidebar.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/browser/browser_customize_sidebar.js | Sidebar box should have an order of 5 when on the right - Got "3", expected "5"

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e482a9b43cbc
Fix for sidebar splitter issues r=desktop-theme-reviewers,sidebar-reviewers,jsudiaman,dao

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e482a9b43cbc

Comment 10

[Kelly Cochrane [:kcochrane]]

Attachment: Rework expand on hover to only overlay the sidebar launcher

Comment 11

[Phabricator Automation]

Comment on attachment 9469437 [details]
Rework expand on hover to only overlay the sidebar launcher

Revision D240171 was moved to bug 1951427. Setting attachment 9469437 [details] to obsolete.