1947849 - Changing the value of BrowsingContext.forceDesktopViewport should trigger a call to MobileViewportManager::RefreshViewportSize

Status: NEW

(Core :: Panning and Zooming, defect, P3)

Description

[Botond Ballo [:botond]]

We have logic for using a different mobile viewport size when the forceDesktopViewport flag is set on the BrowsingContext.

That means the value of this flag is an input to the mobile viewport size computation, and so MobileViewportManager::RefreshViewportSize() should be triggered when the value of flag is changed.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

When I heard this, I thought BrowsingContext doesn't invalidate it, but in fact it does. So probably a bug exists in MobileViewportManager.

Comment 2

[Botond Ballo [:botond]]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)

When I heard this, I thought BrowsingContext doesn't invalidate it, but in fact it does. So probably a bug exists in MobileViewportManager.

Calling MaybeRecreateMobileViewportManager() doesn't perform the invalidation we want, it's more about creating an MVM if there isn't one. In this case, I expect it will take this early exit and be a no-op.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Oh right, that's it!