1948095 - [wpt-sync] Sync PR 50692 - Handle the case when a gradient only have a single stop which contains missing components

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50692 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50692
Details from upstream follow.

CGQAQ <[e-mail]> wrote:

Handle the case when a gradient only have a single stop which contains missing components

In crrev.com/c/4834550 Aaron introduced
ResolveStopColorWithMissingParams for "take neighboring values for
gradient color stops with missing parameters", when I land
crrev.com/c/6197018, you can have only 1 single stop, if it also has
missing components, ResolveStopColorWithMissingParams will never be
called, and the result is we have an empty colors and positions
gradient, and crash the chrome. This CL added a branch to check if the
stops size is 1, and fixed the crash.

Ref: https://issues.chromium.org/issues/344620213#comment5
Bug: 344620213
Change-Id: Ia9c63b485c267f9b6b830357d2a1fdb1174fcb31
Reviewed-on: https://chromium-review.googlesource.com/6253537
WPT-Export-Revision: 40136f0245955e565ed8cf7a2c527c4dcb0b675d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a1a7769a7b7366ed7deff737fef4f312337991b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

PASS: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-images/gradient/gradient-single-stop-none-interpolation.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2e60c2c5bd7
[wpt PR 50692] - Handle the case when a gradient only have a single stop which contains missing components, a=testonly
https://hg.mozilla.org/integration/autoland/rev/254ef2eb1223
[wpt PR 50692] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e2e60c2c5bd7
https://hg.mozilla.org/mozilla-central/rev/254ef2eb1223