1948110 - [wpt-sync] Sync PR 50695 - [testharness.js] Fix issue caused when path contains full stop characters (.)

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50695 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50695
Details from upstream follow.

Johannes Odland <[e-mail]> wrote:

[testharness.js] Fix issue caused when path contains full stop characters (.)

https://github.com/web-platform-tests/wpt/issues/50693

The current implementation of get_title() assumes that the path does not contain a full stop character. If it does, get_title() would return parts of the path, in stead of the filename. The pathname /a.path/filename.html would cause get_title() to return .path instead of the expected filename.

This change fixes the issue by trimming the path away before searching for the extension. It maintains the current behavior, where it only keeps the first part of the filename if the filename contains multiple full stop characters. /path/filename.foo.html still causes filename to be returned.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=99e79af43424e94b2a09453294aba2928579dcb0

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6302507d57aa
[wpt PR 50695] - [testharness.js] Fix issue caused when path contains full stop characters (.), a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6302507d57aa