1948124 - Implement glean probes for integrated RC's new position notification card after auto-open

Status: RESOLVED FIXED

(Firefox :: Shopping, task, P2)

Description

[kpatenio]

In Bug 1945646, we will implement a new card that notifies users of RC's new location, and ask if they want to move RC to the left or right.

Potential new Glean probes for this component:

• the move to right button
• the move to left button
• the dismiss button
• a notification card impression
• settings link to show sidebar settings panel

Let's register the Glean probes in shopping/metrics.yaml
Example Glean probe implementation

Comment 1

[kpatenio]

Attachment: Bug 1948124 - Implement glean probes for integrated RC's new position notification card after auto-open. r=#shopping-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/054d48fbdbf7
Implement glean probes for integrated RC's new position notification card after auto-open. r=shopping-reviewers,jhirsch

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_reviewchecker_show_keep_closed_and_notification_card

Backout link: https://hg.mozilla.org/integration/autoland/rev/4a3bc438cde0495f5194fba71f119f831ec64ab7

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_reviewchecker_show_keep_closed_and_notification_card.js

Buffered messages finished
[task 2025-02-26T06:52:11.141Z] 06:52:11     INFO - TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_reviewchecker_show_keep_closed_and_notification_card.js | Uncaught exception in test bound test_do_not_show_keep_closed_until_notification_dismissed - AbortError: Actor 'SpecialPowers' destroyed before query 'Spawn' was resolved
[task 2025-02-26T06:52:11.141Z] 06:52:11     INFO - Leaving test bound test_do_not_show_keep_closed_until_notification_dismissed
[task 2025-02-26T06:52:11.142Z] 06:52:11     INFO - GECKO(7807) | [Child 8753: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7fe27a071800 == 0 [pid = 8753] [id = 0] [url = https://example.com/Some-Product/dp/ABCDEFG123]
[task 2025-02-26T06:52:11.142Z] 06:52:11     INFO - GECKO(7807) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmprg0k3b_h.mozrunner/runtests_leaks_tab_pid8905.log
[task 2025-02-26T06:52:11.144Z] 06:52:11     INFO - GECKO(7807) | [Child 8753: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (7fe2797d6e00) [pid = 8753] [serial = 1] [outer = 0] [url = https://example.com/Some-Product/dp/ABCDEFG123]
[task 2025-02-26T06:52:11.144Z] 06:52:11     INFO - GECKO(7807) | [Child 8753: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (7fe27a079800) [pid = 8753] [serial = 3] [outer = 0] [url = https://example.com/Some-Product/dp/ABCDEFG123]
[task 2025-02-26T06:52:11.144Z] 06:52:11     INFO - GECKO(7807) | [Child 8753: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (7fe27a073000) [pid = 8753] [serial = 2] [outer = 0] [url = about:blank]
[task 2025-02-26T06:52:11.144Z] 06:52:11     INFO - GECKO(7807) | [Child 8905, Main Thread] WARNING: could not set real-time limit in CubebUtils::InitLibrary: file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp:758
[task 2025-02-26T06:52:11.214Z] 06:52:11     INFO - GECKO(7807) | [Parent 7807: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 26 (7f5c05333a00) [pid = 7807] [serial = 45] [outer = 0] [url = about:about]
[task 2025-02-26T06:52:11.346Z] 06:52:11     INFO - GECKO(7807) | [Parent 7807, Main Thread] WARNING: NS_ENSURE_TRUE(browserChrome) failed: file /builds/worker/checkouts/gecko/dom/base/BarProps.cpp:60
[task 2025-02-26T06:52:11.348Z] 06:52:11     INFO - GECKO(7807) | [Parent 7807, Main Thread] WARNING: NS_ENSURE_TRUE(browserChrome) failed: file /builds/worker/checkouts/gecko/dom/base/BarProps.cpp:60
[task 2025-02-26T06:52:11.359Z] 06:52:11     INFO - GECKO(7807) | MEMORY STAT | vsize 11588MB | residentFast 544MB | heapAllocated 305MB
[task 2025-02-26T06:52:11.361Z] 06:52:11     INFO - TEST-OK | browser/components/shopping/tests/browser/browser_reviewchecker_show_keep_closed_and_notification_card.js | took 2864ms
[task 2025-02-26T06:52:11.361Z] 06:52:11     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-02-26T06:52:11.362Z] 06:52:11     INFO - TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_reviewchecker_show_keep_closed_and_notification_card.js | Found an unexpected tab at the end of test run: https://example.com/Another-Product/dp/HIJKLMN456 - 
[task 2025-02-26T06:52:11.393Z] 06:52:11     INFO - GECKO(7807) | [Child 7923: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7fe27a08c800 == 2 [pid = 7923] [id = 4]

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f07865e10f31
Implement glean probes for integrated RC's new position notification card after auto-open. r=shopping-reviewers,jhirsch

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_reviewchecker_new_position_notification_card.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/fc5ccb17ab40eb559d3195c17ec8adf0adbf6d3c

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_reviewchecker_new_position_notification_card.js | sidebar.position_start is now true - false == true - got false, expected true (operator ==)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/760770575e3c
Implement glean probes for integrated RC's new position notification card after auto-open. r=shopping-reviewers,jhirsch

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/760770575e3c