Closed Bug 1948139 Opened 1 month ago Closed 16 days ago

Add fullscreen / split screen mode styling to AddonsPicker component

Categories

(Firefox :: Messaging System, enhancement, P1)

Product:
Firefox
Component:
Messaging System
Type:
enhancement
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
138 Branch
Iteration:
137.2 - Feb 17 - Feb 28
Tracking Flags:
Tracking Status
firefox137 + fixed
firefox138 + fixed

People

(Reporter: mviar, Assigned: jprickett)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1948139 - Support fullscreen mode for addons screen in onboarding r?#omc-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 1948139 - Support fullscreen mode for addons screen in onboarding r?#omc-reviewers
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review
Summary: Add fullscreen mode styling to AddonsPicker componet → Add fullscreen mode styling to AddonsPicker component
Summary: Add fullscreen mode styling to AddonsPicker component → Add fullscreen / split screen mode styling to AddonsPicker component
Points: --- → 3

[Tracking Requested - why for this release]: We'll request uplift into beta 137 once this patch lands to support a new user experiment set to launch in 137 release.

tracking-firefox138: --- → ?
See Also: → 1952298
Pushed by jprickett@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9831b2c9fffc Support fullscreen mode for addons screen in onboarding r=omc-reviewers,mviar

https://hg.mozilla.org/mozilla-central/rev/9831b2c9fffc

Status: NEW → RESOLVED
Closed: 16 days ago
status-firefox138: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch

This patch changes the markup of the addons picker in fullscreen onboarding to support new designs, and further alters the addons picker styles to support its use in fullscreen split onboarding screens for future experimentation.

Original Revision: https://phabricator.services.mozilla.com/D240095

Attachment #9470945 - Flags: approval-mozilla-beta?

beta Uplift Approval Request

  • User impact if declined: None, inability to run planned experiment in Fx 137
  • Code covered by automated testing: yes
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: Test steps are present in the original patch (https://phabricator.services.mozilla.com/D240095)
  • Risk associated with taking this patch: Minimal
  • Explanation of risk level: Mostly styling changes to an onboarding screen to support upcoming experimentation, and a conditional to allow that screen to use a different layout. Users will not normally see the screen outside of experimentation.
  • String changes made/needed: None
  • Is Android affected?: no
Attachment #9470945 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: